net/spdy/spdy_header_block.h - Issue 1149763005: Change NetLog::ParametersCallback to return a scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_header_block.h

Issue 1149763005: Change NetLog::ParametersCallback to return a scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments on ownership removed Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/spdy/spdy_header_block.h

diff --git a/net/spdy/spdy_header_block.h b/net/spdy/spdy_header_block.h

index b4966422ca499dcfdd552626190df262665a5021..5f5a98d6b5ec4c90094d4610c467344f985d6e21 100644

--- a/net/spdy/spdy_header_block.h

+++ b/net/spdy/spdy_header_block.h

@@ -17,9 +17,8 @@ namespace net {

// SYN_STREAM or SYN_REPLY frame.

typedef std::map<std::string, std::string> SpdyHeaderBlock;

-// Converts a SpdyHeaderBlock into NetLog event parameters. Caller takes

-// ownership of returned value.

-NET_EXPORT base::Value* SpdyHeaderBlockNetLogCallback(

+// Converts a SpdyHeaderBlock into NetLog event parameters.

+NET_EXPORT scoped_ptr<base::Value> SpdyHeaderBlockNetLogCallback(

const SpdyHeaderBlock* headers,

NetLogCaptureMode capture_mode);

« no previous file with comments | « net/socket/websocket_transport_client_socket_pool.cc ('k') | net/spdy/spdy_header_block.cc » ('j') | no next file with comments »