net/quic/quic_http_utils.h - Issue 1149763005: Change NetLog::ParametersCallback to return a scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_http_utils.h

Issue 1149763005: Change NetLog::ParametersCallback to return a scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments on ownership removed Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_http_utils.h

diff --git a/net/quic/quic_http_utils.h b/net/quic/quic_http_utils.h

index 6eafbc0f0929043c05dfeabb29724d6ab5590652..82306d63ce26c5029d6a923d694be7f386757c1e 100644

--- a/net/quic/quic_http_utils.h

+++ b/net/quic/quic_http_utils.h

@@ -19,9 +19,8 @@ NET_EXPORT_PRIVATE QuicPriority ConvertRequestPriorityToQuicPriority(

NET_EXPORT_PRIVATE RequestPriority ConvertQuicPriorityToRequestPriority(

QuicPriority priority);

-// Converts a SpdyHeaderBlock and priority into NetLog event parameters. Caller

-// takes ownership of returned value.

-NET_EXPORT base::Value* QuicRequestNetLogCallback(

+// Converts a SpdyHeaderBlock and priority into NetLog event parameters.

+NET_EXPORT scoped_ptr<base::Value> QuicRequestNetLogCallback(

QuicStreamId stream_id,

const SpdyHeaderBlock* headers,

QuicPriority priority,

« no previous file with comments | « net/quic/quic_connection_logger.cc ('k') | net/quic/quic_http_utils.cc » ('j') | no next file with comments »