Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: net/log/net_log_unittest.cc

Issue 1149763005: Change NetLog::ParametersCallback to return a scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments on ownership removed Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/log/net_log.cc ('k') | net/log/net_log_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/log/net_log_unittest.cc
diff --git a/net/log/net_log_unittest.cc b/net/log/net_log_unittest.cc
index fe794727298a3f8485207a536c87a71f0c0d2bd3..0046b4699f916bb099b96a4e2cb5caa8ca76dff1 100644
--- a/net/log/net_log_unittest.cc
+++ b/net/log/net_log_unittest.cc
@@ -36,14 +36,15 @@ int CaptureModeToInt(NetLogCaptureMode capture_mode) {
return -1;
}
-base::Value* CaptureModeToValue(NetLogCaptureMode capture_mode) {
- return new base::FundamentalValue(CaptureModeToInt(capture_mode));
+scoped_ptr<base::Value> CaptureModeToValue(NetLogCaptureMode capture_mode) {
+ return make_scoped_ptr(
+ new base::FundamentalValue(CaptureModeToInt(capture_mode)));
}
-base::Value* NetCaptureModeCallback(NetLogCaptureMode capture_mode) {
- base::DictionaryValue* dict = new base::DictionaryValue();
+scoped_ptr<base::Value> NetCaptureModeCallback(NetLogCaptureMode capture_mode) {
+ scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
dict->Set("capture_mode", CaptureModeToValue(capture_mode));
- return dict;
+ return dict.Pass();
}
TEST(NetLogTest, Basic) {
« no previous file with comments | « net/log/net_log.cc ('k') | net/log/net_log_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698