Change NetLog::ParametersCallback to return a scoped_ptr.

net/quic/quic_http_utils.cc

Index: net/quic/quic_http_utils.cc
diff --git a/net/quic/quic_http_utils.cc b/net/quic/quic_http_utils.cc
index 9a1c6bbb8964564b85b4543758b3149f4ef8ecf4..60fbd9a4a7f7371fa454b920f4c84aa7ee727bf4 100644
--- a/net/quic/quic_http_utils.cc
+++ b/net/quic/quic_http_utils.cc
@@ -20,15 +20,16 @@ NET_EXPORT_PRIVATE RequestPriority ConvertQuicPriorityToRequestPriority(
       IDLE : static_cast<RequestPriority>(HIGHEST - priority);
 }
 
-base::Value* QuicRequestNetLogCallback(QuicStreamId stream_id,
-                                       const SpdyHeaderBlock* headers,
-                                       QuicPriority priority,
-                                       NetLogCaptureMode capture_mode) {
-  base::DictionaryValue* dict = static_cast<base::DictionaryValue*>(
-      SpdyHeaderBlockNetLogCallback(headers, capture_mode));
+scoped_ptr<base::Value> QuicRequestNetLogCallback(
+    QuicStreamId stream_id,
+    const SpdyHeaderBlock* headers,
+    QuicPriority priority,
+    NetLogCaptureMode capture_mode) {
+  scoped_ptr<base::DictionaryValue> dict(static_cast<base::DictionaryValue*>(
+      SpdyHeaderBlockNetLogCallback(headers, capture_mode).release()));

[eroman, 2015/05/21 03:37:42]

This is weird. Is it needed because of the static_cast ?

[Evan Stade, 2015/05/21 15:30:42]

yea, because of the cast. I don't know of a better way to do it. There's a
GetAsDictionary function but that doesn't play well with scoped_ptr either.

   dict->SetInteger("quic_priority", static_cast<int>(priority));
   dict->SetInteger("quic_stream_id", static_cast<int>(stream_id));
-  return dict;
+  return dict.Pass();
 }
 
 }  // namespace net