Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Side by Side Diff: net/url_request/url_request_redirect_job.cc

Issue 1149763005: Change NetLog::ParametersCallback to return a scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments on ownership removed Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/url_request/url_request_redirect_job.h" 5 #include "net/url_request/url_request_redirect_job.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
11 #include "base/logging.h" 11 #include "base/logging.h"
12 #include "base/message_loop/message_loop.h" 12 #include "base/message_loop/message_loop.h"
13 #include "base/strings/stringprintf.h" 13 #include "base/strings/stringprintf.h"
14 #include "base/values.h"
14 #include "net/base/load_timing_info.h" 15 #include "net/base/load_timing_info.h"
15 #include "net/base/net_errors.h" 16 #include "net/base/net_errors.h"
16 #include "net/http/http_response_headers.h" 17 #include "net/http/http_response_headers.h"
17 #include "net/http/http_util.h" 18 #include "net/http/http_util.h"
18 #include "net/log/net_log.h" 19 #include "net/log/net_log.h"
19 #include "net/url_request/url_request.h" 20 #include "net/url_request/url_request.h"
20 21
21 namespace net { 22 namespace net {
22 23
23 URLRequestRedirectJob::URLRequestRedirectJob(URLRequest* request, 24 URLRequestRedirectJob::URLRequestRedirectJob(URLRequest* request,
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 base::Unretained(fake_headers_.get()))); 118 base::Unretained(fake_headers_.get())));
118 119
119 // TODO(mmenke): Consider calling the NetworkDelegate with the headers here. 120 // TODO(mmenke): Consider calling the NetworkDelegate with the headers here.
120 // There's some weirdness about how to handle the case in which the delegate 121 // There's some weirdness about how to handle the case in which the delegate
121 // tries to modify the redirect location, in terms of how IsSafeRedirect 122 // tries to modify the redirect location, in terms of how IsSafeRedirect
122 // should behave, and whether the fragment should be copied. 123 // should behave, and whether the fragment should be copied.
123 URLRequestJob::NotifyHeadersComplete(); 124 URLRequestJob::NotifyHeadersComplete();
124 } 125 }
125 126
126 } // namespace net 127 } // namespace net
OLDNEW
« no previous file with comments | « net/url_request/url_request_netlog_params.cc ('k') | net/url_request/url_request_throttler_entry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698