Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 1149753005: Updating sandbox flags after Blink-side changes. (Closed)

Created:
5 years, 7 months ago by Mike West
Modified:
5 years, 7 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updating sandbox flags after Blink-side changes. Blink added two sandbox flags; this patch brings //content into line. BUG=483624, 487157 Committed: https://crrev.com/17d29fe84dc5e4645bd38e92d86ee3dd2bc47875 Cr-Commit-Position: refs/heads/master@{#331345}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/common/frame_replication_state.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
Mike West
Jochen, mind stamping this? Not throwing it to the bots yet, as the modals flag ...
5 years, 7 months ago (2015-05-22 14:02:18 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-22 14:16:05 UTC) #3
dcheng
So I've actually been thinking: we should just use WebSandboxFlags directly in content. There's no ...
5 years, 7 months ago (2015-05-22 14:17:53 UTC) #5
dcheng
(I'm happy to do the changes for that if we're OK with that path)
5 years, 7 months ago (2015-05-22 14:18:39 UTC) #6
Mike West
On 2015/05/22 at 14:18:39, dcheng wrote: > (I'm happy to do the changes for that ...
5 years, 7 months ago (2015-05-22 15:44:00 UTC) #7
Mike West
On 2015/05/22 at 15:44:00, Mike West wrote: > On 2015/05/22 at 14:18:39, dcheng wrote: > ...
5 years, 7 months ago (2015-05-22 15:44:23 UTC) #8
dcheng
Either way is OK with me.
5 years, 7 months ago (2015-05-22 15:48:51 UTC) #9
Charlie Reis
[+alexmos for sandbox flag replication] +1 to using the Blink type directly now that we ...
5 years, 7 months ago (2015-05-22 17:30:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149753005/1
5 years, 7 months ago (2015-05-26 10:09:10 UTC) #13
Mike West
On 2015/05/22 at 17:30:25, creis wrote: > [+alexmos for sandbox flag replication] > > +1 ...
5 years, 7 months ago (2015-05-26 10:09:15 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-26 11:16:20 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 11:17:18 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17d29fe84dc5e4645bd38e92d86ee3dd2bc47875
Cr-Commit-Position: refs/heads/master@{#331345}

Powered by Google App Engine
This is Rietveld 408576698