Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Unified Diff: net/http/transport_security_state.h

Issue 1149753002: Normalize hostnames before searching for HSTS/HPKP preloads (Closed) Base URL:
Patch Set: ODR cleanup Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/ » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/transport_security_state.h
diff --git a/net/http/transport_security_state.h b/net/http/transport_security_state.h
index 3d2292666a1c7419a0224543ec482517e2ecd7c1..2cbd5ef52ba7a34e6af43d880d323f6973cab36e 100644
--- a/net/http/transport_security_state.h
+++ b/net/http/transport_security_state.h
@@ -193,8 +193,7 @@ class NET_EXPORT TransportSecurityState
void ClearDynamicData();
// Inserts |state| into |enabled_hosts_| under the key |hashed_host|.
- // |hashed_host| is already in the internal representation
- // HashHost(CanonicalizeHost(host)).
+ // |hashed_host| is already in the internal representation.
// Note: This is only used for serializing/deserializing the
// TransportSecurityState.
void AddOrUpdateEnabledHosts(const std::string& hashed_host,
@@ -319,11 +318,6 @@ class NET_EXPORT TransportSecurityState
// The new state for |host| is persisted using the Delegate (if any).
void EnableHost(const std::string& host, const DomainState& state);
- // Converts |hostname| from dotted form ("") to the form
- // used in DNS: "\x03www\x06google\x03com", lowercases that, and returns
- // the result.
- static std::string CanonicalizeHost(const std::string& hostname);
// The set of hosts that have enabled TransportSecurity. |sts.domain| and
// |pkp.domain| will always be empty for a DomainState in this map; the domain
// comes from the map key instead.
« no previous file with comments | « no previous file | net/http/ » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698