appengine/findit/waterfall/analyze_build_failure_pipeline.py - Issue 1149743002: [Findit] Use step level analysis to exclude flaky test failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/analyze_build_failure_pipeline.py

Issue 1149743002: [Findit] Use step level analysis to exclude flaky test failures. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Fix name style nit. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: appengine/findit/waterfall/analyze_build_failure_pipeline.py

diff --git a/appengine/findit/waterfall/analyze_build_failure_pipeline.py b/appengine/findit/waterfall/analyze_build_failure_pipeline.py

index fd879f2884c4fd7995817cd634745a2a6093e92e..ae80c8b163b0f0254d1a4ae5b5200d53549bbdf8 100644

--- a/appengine/findit/waterfall/analyze_build_failure_pipeline.py

+++ b/appengine/findit/waterfall/analyze_build_failure_pipeline.py

@@ -28,7 +28,7 @@ class AnalyzeBuildFailurePipeline(BasePipeline):

Args:

was_aborted (bool): True if the pipeline was aborted, otherwise False.

"""

- if was_aborted:

+ if was_aborted:

analysis = WfAnalysis.Get(

self.master_name, self.builder_name, self.build_number)

if analysis: # In case the analysis is deleted manually.

@@ -37,7 +37,7 @@ class AnalyzeBuildFailurePipeline(BasePipeline):

analysis.put()

def finalized(self):

- self._LogUnexpectedAborting(self.was_aborted)

+ self._LogUnexpectedAborting(self.was_aborted)

def pipeline_status_path(self):

"""Returns an absolute path to look up the status of the pipeline."""

« no previous file with comments | « appengine/findit/cloudstorage ('k') | appengine/findit/waterfall/buildbot.py » ('j') | no next file with comments »