Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: appengine/findit/waterfall/test/buildbot_test.py

Issue 1149743002: [Findit] Use step level analysis to exclude flaky test failures. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Fix name style nit. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from datetime import datetime 5 from datetime import datetime
6 import gzip
6 import os 7 import os
7 import unittest 8 import unittest
8 9
9 from common.retry_http_client import RetryHttpClient 10 from common.retry_http_client import RetryHttpClient
10 from waterfall import buildbot 11 from waterfall import buildbot
11 12
12 13
13 class DummyHttpClient(RetryHttpClient): 14 class DummyHttpClient(RetryHttpClient):
14 15
15 def __init__(self, status_code, response_content): 16 def __init__(self, status_code, response_content):
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 step_name = '[trigger] abc_tests' 114 step_name = '[trigger] abc_tests'
114 expected_stdio_log_url = ('https://build.chromium.org/p/a/builders/' 115 expected_stdio_log_url = ('https://build.chromium.org/p/a/builders/'
115 'Win7%20Tests%20%281%29/builds/123/steps/' 116 'Win7%20Tests%20%281%29/builds/123/steps/'
116 '%5Btrigger%5D%20abc_tests/logs/stdio/text') 117 '%5Btrigger%5D%20abc_tests/logs/stdio/text')
117 118
118 self.assertEqual( 119 self.assertEqual(
119 expected_stdio_log_url, 120 expected_stdio_log_url,
120 buildbot.CreateStdioLogUrl( 121 buildbot.CreateStdioLogUrl(
121 master_name, builder_name, build_number, step_name)) 122 master_name, builder_name, build_number, step_name))
122 123
124 def testCreateGtestResultPath(self):
125 master_name = 'a'
126 builder_name = 'Win7 Tests (1)'
127 build_number = 123
128 step_name = '[trigger] abc_tests'
129 expected_stdio_log_url = ('/chrome-gtest-results/buildbot/a/Win7 Tests '
130 '(1)/123/[trigger] abc_tests.json.gz')
131
132 self.assertEqual(
133 expected_stdio_log_url,
134 buildbot.CreateGtestResultPath(
135 master_name, builder_name, build_number, step_name))
136
123 def testGetBuildDataFromArchiveSuccess(self): 137 def testGetBuildDataFromArchiveSuccess(self):
124 master_name = 'a' 138 master_name = 'a'
125 builder_name = 'b c' 139 builder_name = 'b c'
126 build_number = 1 140 build_number = 1
127 expected_url = ('https://chrome-build-extract.appspot.com/p/a/builders/' 141 expected_url = ('https://chrome-build-extract.appspot.com/p/a/builders/'
128 'b%20c/builds/1?json=1') 142 'b%20c/builds/1?json=1')
129 http_client = DummyHttpClient(200, 'abc') 143 http_client = DummyHttpClient(200, 'abc')
130 data = buildbot.GetBuildDataFromArchive( 144 data = buildbot.GetBuildDataFromArchive(
131 master_name, builder_name, build_number, http_client) 145 master_name, builder_name, build_number, http_client)
132 self.assertEqual(http_client.response_content, data) 146 self.assertEqual(http_client.response_content, data)
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
329 self.assertEqual(master_name, build_info.master_name) 343 self.assertEqual(master_name, build_info.master_name)
330 self.assertEqual(builder_name, build_info.builder_name) 344 self.assertEqual(builder_name, build_info.builder_name)
331 self.assertEqual(build_number, build_info.build_number) 345 self.assertEqual(build_number, build_info.build_number)
332 self.assertEqual(expected_build_start_time, build_info.build_start_time) 346 self.assertEqual(expected_build_start_time, build_info.build_start_time)
333 self.assertEqual(expected_chromium_revision, build_info.chromium_revision) 347 self.assertEqual(expected_chromium_revision, build_info.chromium_revision)
334 self.assertEqual(expected_completed, build_info.completed) 348 self.assertEqual(expected_completed, build_info.completed)
335 self.assertEqual(expected_result, build_info.result) 349 self.assertEqual(expected_result, build_info.result)
336 self.assertEqual(expected_blame_list, build_info.blame_list) 350 self.assertEqual(expected_blame_list, build_info.blame_list)
337 self.assertEqual(expected_failed_steps, build_info.failed_steps) 351 self.assertEqual(expected_failed_steps, build_info.failed_steps)
338 self.assertEqual(expected_passed_steps, build_info.passed_steps) 352 self.assertEqual(expected_passed_steps, build_info.passed_steps)
OLDNEW
« no previous file with comments | « appengine/findit/waterfall/extract_signal_pipeline.py ('k') | appengine/findit/waterfall/test/data/m_b_123_abc_test.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698