Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1149723002: [test] Fix simdjs perf tests. (Closed)

Created:
5 years, 7 months ago by Michael Achenbach
Modified:
5 years, 7 months ago
Reviewers:
bbudge, bradnelson, bradn
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Fix simdjs perf tests. - Missing resource on android - Higher timeout on arm - Fewer runs on arm - Drop total BUG=v8:4124 LOG=N NOTRY=true TBR=bradnelson@chromium.org Committed: https://crrev.com/37706b3ddf4597b3322f7ab4d2c767ad3503fe12 Cr-Commit-Position: refs/heads/master@{#28528}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Keep old name #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M test/simdjs/SimdJs.json View 1 2 3 chunks +8 lines, -1 line 0 comments Download
M test/simdjs/generate.py View 1 2 2 chunks +10 lines, -3 lines 1 comment Download

Messages

Total messages: 14 (6 generated)
Michael Achenbach
PTAL. Feel free to hit the CQ if this looks alright.
5 years, 7 months ago (2015-05-20 18:23:41 UTC) #3
Michael Achenbach
PTAL at patch 3
5 years, 7 months ago (2015-05-20 18:28:59 UTC) #4
bradn
lgtm https://codereview.chromium.org/1149723002/diff/40001/test/simdjs/generate.py File test/simdjs/generate.py (right): https://codereview.chromium.org/1149723002/diff/40001/test/simdjs/generate.py#newcode62 test/simdjs/generate.py:62: with open(os.path.join(SCRIPT_DIR, 'SimdJs.json'), 'w') as fh: wow, how'd ...
5 years, 7 months ago (2015-05-20 18:29:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149723002/40001
5 years, 7 months ago (2015-05-20 18:29:50 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-05-20 18:29:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149723002/40001
5 years, 7 months ago (2015-05-20 18:32:14 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-20 18:33:59 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 18:34:15 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/37706b3ddf4597b3322f7ab4d2c767ad3503fe12
Cr-Commit-Position: refs/heads/master@{#28528}

Powered by Google App Engine
This is Rietveld 408576698