Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 11497009: Revive throw as an expression but not for rethrow. (Closed)

Created:
8 years ago by ngeoffray
Modified:
8 years ago
Reviewers:
ahe, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revive throw as an expression but not for rethrow.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -22 lines) Patch
M sdk/lib/_internal/compiler/implementation/scanner/listener.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/parser.dart View 3 chunks +7 lines, -8 lines 2 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 2 chunks +7 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/validate.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/tree/nodes.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/co19/co19-dart2js.status View 3 chunks +0 lines, -3 lines 0 comments Download
A tests/language/throw_expression_test.dart View 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ngeoffray
8 years ago (2012-12-10 14:32:29 UTC) #1
kasperl
LGTM. Do you have a negative test that ensures that we cannot have rethrow in ...
8 years ago (2012-12-10 14:50:05 UTC) #2
kasperl
We just chatted more about this. It seems pretty broken. The scary stuff is code ...
8 years ago (2012-12-10 15:01:22 UTC) #3
ngeoffray
8 years ago (2012-12-11 09:32:19 UTC) #4
Thanks for taking a look. I'm closing this CL for now until the spec gets
updated.

Powered by Google App Engine
This is Rietveld 408576698