 Chromium Code Reviews
 Chromium Code Reviews Issue 1149673002:
  Adding blink gc memory dump infrastructure for thread specific dumps.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master
    
  
    Issue 1149673002:
  Adding blink gc memory dump infrastructure for thread specific dumps.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: Source/platform/heap/BlinkGCMemoryDumpProvider.h | 
| diff --git a/Source/platform/heap/BlinkGCMemoryDumpProvider.h b/Source/platform/heap/BlinkGCMemoryDumpProvider.h | 
| index 1ed934947dbb4b651a9b3213e8327a56b3d6108c..7bd86b4853cb14a38e10e9c7fd53cd0ed24b589c 100644 | 
| --- a/Source/platform/heap/BlinkGCMemoryDumpProvider.h | 
| +++ b/Source/platform/heap/BlinkGCMemoryDumpProvider.h | 
| @@ -6,9 +6,13 @@ | 
| #define BlinkGCMemoryDumpProvider_h | 
| #include "platform/PlatformExport.h" | 
| +#include "platform/TraceEvent.h" | 
| 
Primiano Tucci (use gerrit)
2015/05/27 14:19:30
do you really need this or is just a leftover from
 
ssid
2015/05/27 14:39:33
Forgot to upload the last patch.
 | 
| #include "public/platform/WebMemoryDumpProvider.h" | 
| +#include "wtf/OwnPtr.h" | 
| +#include "wtf/text/WTFString.h" | 
| namespace blink { | 
| +class WebMemoryAllocatorDump; | 
| class PLATFORM_EXPORT BlinkGCMemoryDumpProvider final : public WebMemoryDumpProvider { | 
| public: | 
| @@ -18,8 +22,12 @@ public: | 
| // WebMemoryDumpProvider implementation. | 
| bool onMemoryDump(WebProcessMemoryDump*) override; | 
| + WebMemoryAllocatorDump* createMemoryAllocatorDumpForCurrentGC(const String& absoluteName); | 
| 
Primiano Tucci (use gerrit)
2015/05/27 14:19:31
Can you add a comment clarifying that:
- the retur
 
ssid
2015/05/27 14:39:33
Done.
 | 
| + | 
| private: | 
| BlinkGCMemoryDumpProvider(); | 
| + | 
| + OwnPtr<WebProcessMemoryDump> m_currentProcessMemoryDump; | 
| }; | 
| } // namespace blink |