Source/platform/heap/Heap.h - Issue 1149673002: Adding blink gc memory dump infrastructure for thread specific dumps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/heap/Heap.h

Issue 1149673002: Adding blink gc memory dump infrastructure for thread specific dumps. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixing nits. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/platform/heap/BlinkGCMemoryDumpProvider.cpp ('K') | « Source/platform/heap/BlinkGCMemoryDumpProvider.cpp ('k') | Source/platform/heap/Heap.cpp » ('j') | Source/platform/heap/Heap.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/heap/Heap.h

diff --git a/Source/platform/heap/Heap.h b/Source/platform/heap/Heap.h

index 3d6a7c5980072a38b68e3e67be2d10c9a6d2e874..9a104de90516a7e962e61ca25494664f2b418bfd 100644

--- a/Source/platform/heap/Heap.h

+++ b/Source/platform/heap/Heap.h

@@ -95,6 +95,7 @@ class FreePagePool;

class NormalPageHeap;

class OrphanedPagePool;

class PageMemory;

+class WebProcessMemoryDump;

Primiano Tucci (use gerrit) 2015/05/22 19:45:57 I think you don't need this anymore.

ssid 2015/05/26 11:08:43 Done.

#if ENABLE(GC_PROFILING)

class TracedValue;

@@ -686,6 +687,7 @@ public:

virtual ~BaseHeap();

void cleanupPages();

+ void dumpMemory(const String& allocatorBaseName);

#if ENABLE(ASSERT) || ENABLE(GC_PROFILING)

BasePage* findPageFromAddress(Address);

#endif