Adding blink gc memory dump infrastructure for thread specific dumps.

Source/platform/heap/BlinkGCMemoryDumpProvider.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "Source/platform/heap/BlinkGCMemoryDumpProvider.h"
 
 #include "platform/heap/Handle.h"
 #include "public/platform/WebMemoryAllocatorDump.h"
 #include "public/platform/WebProcessMemoryDump.h"
 #include "wtf/StdLibExtras.h"
 
 namespace blink {
 
 BlinkGCMemoryDumpProvider* BlinkGCMemoryDumpProvider::instance()
 {
     DEFINE_STATIC_LOCAL(BlinkGCMemoryDumpProvider, instance, ());
     return &instance;
 }
 
-bool BlinkGCMemoryDumpProvider::onMemoryDump(blink::WebProcessMemoryDump* memoryDump)
+BlinkGCMemoryDumpProvider::~BlinkGCMemoryDumpProvider()
 {
+}
+
+bool BlinkGCMemoryDumpProvider::onMemoryDump(WebProcessMemoryDump* memoryDump)
+{
+    // The current heap statistics are added to the memory dump.
     WebMemoryAllocatorDump* allocatorDump = memoryDump->createMemoryAllocatorDump("blink_gc");
     allocatorDump->AddScalar("inner_size", "bytes", Heap::allocatedObjectSize());
     allocatorDump->AddScalar("outer_size", "bytes", Heap::allocatedSpace());
     allocatorDump->AddScalar("estimated_live_object_size", "bytes", Heap::estimatedLiveObjectSize());
+
+    // If available, the last GC memory statistics are added.
+    if (Heap::getLastProcessMemoryDump())
+        memoryDump->takeAllDumpsFrom(Heap::getLastProcessMemoryDump());

[Primiano Tucci (use gerrit), 2015/05/22 15:50:21]

Ok here you need the TODO pointing to crbug.com/490783 and you should have an
"else: return false" once 490783 gets fixed.

[ssid, 2015/05/22 16:05:16]

But we are dumping some overall numbers even if the last gc dump isn't
available. Also, there can be cases where we are dumping empty dumps, which
can't be detected here. ie, no GC happened in between and we still swap the
empty object.

+
     return true;
 }
 
 BlinkGCMemoryDumpProvider::BlinkGCMemoryDumpProvider()
 {
 }
 
-BlinkGCMemoryDumpProvider::~BlinkGCMemoryDumpProvider()

[Primiano Tucci (use gerrit), 2015/05/22 15:50:21]

Is this intended? I think you accidentally removed the dtor (it's still there in
the header)

[ssid, 2015/05/22 16:05:16]

It is moved up to maintain the function order in header.

-{
-}
-
 } // namespace blink