Introduce a new gyp flag to warn about to be deprecated APIs

include/v8config.h

Index: include/v8config.h
diff --git a/include/v8config.h b/include/v8config.h
index 991a43afd445c066eda7d5fc6e5d56209a5a0cf4..c2b856bd7dd9c3a33002d0c2e4208c950e04d90c 100644
--- a/include/v8config.h
+++ b/include/v8config.h
@@ -328,7 +328,18 @@ declarator __attribute__((deprecated))
 
 
 // a macro to make it easier to see what will be deprecated.

[vogelheim, 2015/05/21 09:17:09]

"a macro" => "a plethora of macros".

Or maybe, put V8_DEPRECATE_SOON into the lead-in comment, since it's now pretty
hard to see what is actually being defined here. I at least had to read a good
bit to be sure that this block will always define V8_DEPRECATE_SOON (and nothing
else). Same above.

+#if defined(V8_IMMINENT_DEPRECATION_WARNINGS) && \
+    V8_HAS_ATTRIBUTE_DEPRECATED_MESSAGE
+#define V8_DEPRECATE_SOON(message, declarator) \
+  declarator __attribute__((deprecated(message)))

[vogelheim, 2015/05/21 09:17:09]

Style nitpick: Indent is weird. It's 4 chars above, 2 chars here. Not sure what
we even want here. There's no indent at all in the block above.

[jochen (gone - plz use gerrit), 2015/05/21 09:30:31]

it's what clang-format does :-/

the block above is hand-written, I can clang-format it as well...

[vogelheim, 2015/05/21 09:39:20]

It's fine, then. All glory to clang-format!

+#elif defined(V8_IMMINENT_DEPRECATION_WARNINGS) && V8_HAS_ATTRIBUTE_DEPRECATED
+#define V8_DEPRECATE_SOON(message, declarator) \
+  declarator __attribute__((deprecated))
+#elif defined(V8_IMMINENT_DEPRECATION_WARNINGS) && V8_HAS_DECLSPEC_DEPRECATED
+#define V8_DEPRECATE_SOON(message, declarator) __declspec(deprecated) declarator
+#else
 #define V8_DEPRECATE_SOON(message, declarator) declarator
+#endif
 
 
 // A macro to provide the compiler with branch prediction information.