Introduce a new gyp flag to warn about to be deprecated APIs

Introduce a new gyp flag to warn about to be deprecated APIs

This should help to keep syntax errors from creeping into v8.h

Also, I'll remove usages of to-be-deprecated APIs and turn this flag on
for standalone builds

BUG=4134
R=vogelheim@chromium.org
LOG=n

Committed: https://crrev.com/29deaef505b5868f2bbe635d76cded6c8c0b67e4
Cr-Commit-Position: refs/heads/master@{#28538}

[vogelheim, 2015-05-21 09:17:09]

lgtm. Some nitpicks, though.

https://codereview.chromium.org/1149633003/diff/1/Makefile
File Makefile (right):

https://codereview.chromium.org/1149633003/diff/1/Makefile#newcode152
Makefile:152: # imminent_deprecation_warnings=on
spelling?

I take it the comment is meant to document the option, in which case it should
be spelled the same as the actual option. (That is, with the same number of
underscores.)

(Also, same issue above on deprecation_warnings, but not strictly relates to
your code.)

https://codereview.chromium.org/1149633003/diff/1/include/v8config.h
File include/v8config.h (right):

https://codereview.chromium.org/1149633003/diff/1/include/v8config.h#newcode330
include/v8config.h:330: // a macro to make it easier to see what will be
deprecated.
"a macro" => "a plethora of macros".

Or maybe, put V8_DEPRECATE_SOON into the lead-in comment, since it's now pretty
hard to see what is actually being defined here. I at least had to read a good
bit to be sure that this block will always define V8_DEPRECATE_SOON (and nothing
else). Same above.

https://codereview.chromium.org/1149633003/diff/1/include/v8config.h#newcode334
include/v8config.h:334: declarator __attribute__((deprecated(message)))
Style nitpick: Indent is weird. It's 4 chars above, 2 chars here. Not sure what
we even want here. There's no indent at all in the block above.

[jochen (gone - plz use gerrit), 2015-05-21 09:30:32]

ptal

https://codereview.chromium.org/1149633003/diff/1/include/v8config.h
File include/v8config.h (right):

https://codereview.chromium.org/1149633003/diff/1/include/v8config.h#newcode334
include/v8config.h:334: declarator __attribute__((deprecated(message)))
On 2015/05/21 at 09:17:09, vogelheim wrote:
> Style nitpick: Indent is weird. It's 4 chars above, 2 chars here. Not sure
what we even want here. There's no indent at all in the block above.

it's what clang-format does :-/

the block above is hand-written, I can clang-format it as well...

[vogelheim, 2015-05-21 09:39:21]

lgtm

A bit more nitpickery, though.

https://codereview.chromium.org/1149633003/diff/1/include/v8config.h
File include/v8config.h (right):

https://codereview.chromium.org/1149633003/diff/1/include/v8config.h#newcode334
include/v8config.h:334: declarator __attribute__((deprecated(message)))
On 2015/05/21 09:30:31, jochen wrote:
> On 2015/05/21 at 09:17:09, vogelheim wrote:
> > Style nitpick: Indent is weird. It's 4 chars above, 2 chars here. Not sure
> what we even want here. There's no indent at all in the block above.
> 
> it's what clang-format does :-/
> 
> the block above is hand-written, I can clang-format it as well...

It's fine, then. All glory to clang-format!

https://codereview.chromium.org/1149633003/diff/20001/include/v8config.h
File include/v8config.h (right):

https://codereview.chromium.org/1149633003/diff/20001/include/v8config.h#newc...
include/v8config.h:316: // A macro (V8_DEPRECASTED) to mark classes or functions
as deprecated.
V8_DEPRECASTED => V8_DEPRECATED

https://codereview.chromium.org/1149633003/diff/20001/include/v8config.h#newc...
include/v8config.h:330: // a macro (V8_DEPRECATE_SOON) to make it easier to see
what will be deprecated.
Super nitpick: Capital A in "A macro ..."

[jochen (gone - plz use gerrit), 2015-05-21 09:43:09]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-05-21 09:43:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/1149633003/#ps40001
(title: "updates")

[commit-bot: I haz the power, 2015-05-21 09:43:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1149633003/40001

[commit-bot: I haz the power, 2015-05-21 10:34:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-21 10:35:05]

Patchset 3 (id:??) landed as
https://crrev.com/29deaef505b5868f2bbe635d76cded6c8c0b67e4
Cr-Commit-Position: refs/heads/master@{#28538}