Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1149623011: Standalone checkout gets buildtools. (Closed)

Created:
5 years, 6 months ago by Tom Sepez
Modified:
5 years, 6 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Standalone checkout gets buildtools. This will pull in the checkdeps utility for standalone builds. Write some include rules, too. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/211f90e1bc5d855a2fce3e5f4f6d60d59667894e

Patch Set 1 #

Patch Set 2 : write some deps include_rules #

Patch Set 3 : Roll buildtools forward. #

Total comments: 2

Patch Set 4 : Alphabetize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 2 3 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Tom Sepez
Lei, for review.
5 years, 6 months ago (2015-06-05 18:39:27 UTC) #2
Lei Zhang
lgtm
5 years, 6 months ago (2015-06-05 18:44:29 UTC) #3
Tom Sepez
On 2015/06/05 18:44:29, Lei Zhang wrote: > lgtm Waiting on https://codereview.chromium.org/1154753008/
5 years, 6 months ago (2015-06-05 18:51:53 UTC) #4
Tom Sepez
And its ready to go. Lei, final look.
5 years, 6 months ago (2015-06-05 20:09:39 UTC) #5
Lei Zhang
lgtm https://codereview.chromium.org/1149623011/diff/40001/DEPS File DEPS (right): https://codereview.chromium.org/1149623011/diff/40001/DEPS#newcode34 DEPS:34: '+public', alphabetical order?
5 years, 6 months ago (2015-06-05 20:14:13 UTC) #6
Tom Sepez
https://codereview.chromium.org/1149623011/diff/40001/DEPS File DEPS (right): https://codereview.chromium.org/1149623011/diff/40001/DEPS#newcode34 DEPS:34: '+public', On 2015/06/05 20:14:13, Lei Zhang wrote: > alphabetical ...
5 years, 6 months ago (2015-06-05 20:34:27 UTC) #7
Tom Sepez
5 years, 6 months ago (2015-06-05 20:34:51 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
211f90e1bc5d855a2fce3e5f4f6d60d59667894e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698