src/isolate.cc - Issue 1149623010: Print and save JS stacktrace on OOM crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/isolate.cc

Issue 1149623010: Print and save JS stacktrace on OOM crash. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/isolate.cc

diff --git a/src/isolate.cc b/src/isolate.cc

index efa0e28ba06529c788ef3dc6e19e37494b897dd5..57b23bcb51db2b0815c10390fd2b5529af8908d3 100644

--- a/src/isolate.cc

+++ b/src/isolate.cc

@@ -705,7 +705,7 @@ static void PrintFrames(Isolate* isolate,

void Isolate::PrintStack(StringStream* accumulator, PrintStackMode mode) {

// The MentionedObjectCache is not GC-proof at the moment.

DisallowHeapAllocation no_gc;

- DCHECK(StringStream::IsMentionedObjectCacheClear(this));

+ DCHECK(accumulator->IsMentionedObjectCacheClear(this));

// Avoid printing anything if there are no frames.

if (c_entry_fp(thread_local_top()) == 0) return;