Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(24)

Issue 1149623010: Print and save JS stacktrace on OOM crash. (Closed)

Created:
5 years, 6 months ago by ulan
Modified:
5 years, 6 months ago
CC:
Erik Corry Chromium.org, Hannes Payer (out of office), v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Print and save JS stacktrace on OOM crash. BUG= Committed: https://crrev.com/25981994b781624518540e9fc28c09a40d635245 Cr-Commit-Position: refs/heads/master@{#28818}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -10 lines) Patch
M src/api.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M src/heap/heap.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/string-stream.h View 1 4 chunks +25 lines, -6 lines 0 comments Download
M src/string-stream.cc View 4 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ulan
PTAL. This helps with postmortem debugging of OOM.
5 years, 6 months ago (2015-06-05 15:57:02 UTC) #2
jochen (gone - plz use gerrit)
lgtm with nits https://codereview.chromium.org/1149623010/diff/1/src/string-stream.h File src/string-stream.h (right): https://codereview.chromium.org/1149623010/diff/1/src/string-stream.h#newcode42 src/string-stream.h:42: ~FixedStringAllocator() {} override https://codereview.chromium.org/1149623010/diff/1/src/string-stream.h#newcode49 src/string-stream.h:49: }; ...
5 years, 6 months ago (2015-06-05 16:03:43 UTC) #3
ulan
Thank, addressed comments. Landing.
5 years, 6 months ago (2015-06-05 16:17:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149623010/20001
5 years, 6 months ago (2015-06-05 16:18:02 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-05 17:15:57 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 17:16:15 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/25981994b781624518540e9fc28c09a40d635245
Cr-Commit-Position: refs/heads/master@{#28818}

Powered by Google App Engine
This is Rietveld 408576698