Issue 1149623004: [bindings] Implment postMessageImpl and replace the usage of postMessageMethodCommon.

Issue 1149623004: [bindings] Implment postMessageImpl and replace the usage of postMessageMethodCommon. (Closed)

Created:
5 years, 6 months ago by vivekg_samsung

Modified:
5 years, 6 months ago

Reviewers:
haraken, vivekg

CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

[bindings] Implment postMessageImpl and replace the usage of postMessageMethodCommon. Moving the postMessageMethodCommon to postMessageImpl and removing the PostMessage.h BUG=345519 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195977

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -58 lines)			Patch
D	Source/bindings/core/v8/PostMessage.h	View	1 chunk	+0 lines, -51 lines	0 comments	Download
M	Source/bindings/core/v8/v8.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/bindings/scripts/v8_methods.py	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	Source/bindings/templates/interface_base.cpp	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	Source/bindings/templates/methods.cpp	View	2 chunks	+30 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/core/V8TestObject.cpp	View	3 chunks	+29 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

vivekg

PTAL. Renaming to postMessageImpl and removing the PostMessage.h

5 years, 6 months ago (2015-05-27 05:36:28 UTC) #2

vivekg

On 2015/05/27 07:05:05, haraken wrote: > LGTM. You'll need to remove PostMessage.h from gni. The ...

5 years, 6 months ago (2015-05-27 07:12:46 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149623004/1

5 years, 6 months ago (2015-05-27 12:53:53 UTC) #6

commit-bot: I haz the power

5 years, 6 months ago (2015-05-27 12:57:15 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195977