Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issue 1149623002: [iOS] Upstream UpdateSearchEnginesIfNeeded (Closed)

Created:
5 years, 7 months ago by sdefresne
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Upstream UpdateSearchEnginesIfNeeded On iOS when user chaneg the device locale, we update the list of search engines keeping the currently selected search engine unchanged. This is done by removing all other search engines, and then adding the new ones. BUG=None Committed: https://crrev.com/8abf4df08fd2bcfb7f2f651bc539bad03060091e Cr-Commit-Position: refs/heads/master@{#330913}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -1 line) Patch
M ios/chrome/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A ios/chrome/browser/search_engines/search_engines_util.h View 1 chunk +22 lines, -0 lines 0 comments Download
A ios/chrome/browser/search_engines/search_engines_util.cc View 1 chunk +113 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
sdefresne
noyau: Please take a look. pkasting: OWNERS approval for new DEPS on //components/search_engines
5 years, 7 months ago (2015-05-20 13:01:43 UTC) #2
noyau (Ping after 24h)
lgtm
5 years, 7 months ago (2015-05-20 13:17:43 UTC) #3
sdefresne
pkasting: OWNERS approval for new DEPS on //components/search_engines
5 years, 7 months ago (2015-05-20 14:05:43 UTC) #5
Peter Kasting
LGTM
5 years, 7 months ago (2015-05-20 19:54:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149623002/1
5 years, 7 months ago (2015-05-21 07:53:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-21 07:57:19 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 07:58:42 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8abf4df08fd2bcfb7f2f651bc539bad03060091e
Cr-Commit-Position: refs/heads/master@{#330913}

Powered by Google App Engine
This is Rietveld 408576698