Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 11496004: Lazy initialization for PushMessagingEventRouter (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 6ca023859a6f4daf4920098af5aa838332581882..c2a467f89c54592d64116835d030e7c8caba4214 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -38,7 +38,6 @@
#include "chrome/browser/extensions/api/font_settings/font_settings_api.h"
#include "chrome/browser/extensions/api/media_galleries_private/media_galleries_private_event_router.h"
#include "chrome/browser/extensions/api/preference/preference_api.h"
-#include "chrome/browser/extensions/api/push_messaging/push_messaging_api.h"
#include "chrome/browser/extensions/api/runtime/runtime_api.h"
#include "chrome/browser/extensions/api/web_navigation/web_navigation_api.h"
#include "chrome/browser/extensions/app_notification_manager.h"
@@ -548,8 +547,6 @@ void ExtensionService::InitEventRouters() {
new extensions::WebNavigationEventRouter(profile_));
font_settings_event_router_.reset(
new extensions::FontSettingsEventRouter(profile_));
- push_messaging_event_router_.reset(
- new extensions::PushMessagingEventRouter(profile_));
media_galleries_private_event_router_.reset(
new extensions::MediaGalleriesPrivateEventRouter(profile_));
@@ -567,13 +564,6 @@ void ExtensionService::InitEventRouters() {
event_routers_initialized_ = true;
}
-void ExtensionService::OnProfileSyncServiceShutdown() {
- // TODO(akalin): Move this block to Shutdown() once
- // http://crbug.com/153827 is fixed.
- if (push_messaging_event_router_.get())
- push_messaging_event_router_->Shutdown();
-}
-
void ExtensionService::Shutdown() {
// Do nothing for now.
}

Powered by Google App Engine
This is Rietveld 408576698