Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1257)

Unified Diff: chrome/browser/sync/profile_sync_service.cc

Issue 11496004: Lazy initialization for PushMessagingEventRouter (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/profile_sync_service.cc
diff --git a/chrome/browser/sync/profile_sync_service.cc b/chrome/browser/sync/profile_sync_service.cc
index 03eb325dc1fb64e65885785e742dcf8f3e01ea57..866ea4c5d5d16767ac4ae2f1fd52874d097bcf27 100644
--- a/chrome/browser/sync/profile_sync_service.cc
+++ b/chrome/browser/sync/profile_sync_service.cc
@@ -25,8 +25,7 @@
#include "chrome/browser/about_flags.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/defaults.h"
-#include "chrome/browser/extensions/extension_service.h"
-#include "chrome/browser/extensions/extension_system.h"
+#include "chrome/browser/extensions/api/push_messaging/push_messaging_api.h"
akalin 2012/12/10 20:37:12 remove this too
Joe Thomas 2012/12/10 22:43:58 Done.
#include "chrome/browser/net/chrome_cookie_notification_details.h"
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/browser/profiles/profile.h"
@@ -518,12 +517,11 @@ void ProfileSyncService::EmitInvalidationForTest(
void ProfileSyncService::Shutdown() {
DCHECK(invalidator_registrar_.get());
// TODO(akalin): Remove this once http://crbug.com/153827 is fixed.
akalin 2012/12/10 20:37:12 remove this too
Joe Thomas 2012/12/10 22:43:58 Done.
- ExtensionService* const extension_service =
- extensions::ExtensionSystem::Get(profile_)->extension_service();
- // |extension_service| may be NULL if it was never initialized
- // (e.g., extension sync wasn't enabled in tests).
- if (extension_service)
- extension_service->OnProfileSyncServiceShutdown();
+ extensions::PushMessagingAPI* const push_messaging_api =
+ extensions::PushMessagingAPI::Get(profile_);
+ // |push_messaging_api| may be NULL if the service was never initialized.
+ if (push_messaging_api)
+ push_messaging_api->OnProfileSyncServiceShutdown();
// Reset |invalidator_registrar_| first so that ShutdownImpl cannot
// use it.

Powered by Google App Engine
This is Rietveld 408576698