Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: include/v8.h

Issue 1149563011: Verify a bit more about external strings (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 56fe98d40415583a335ae62e893e05f7766cdf0d..0c193b003849bc4bb34d1b06c228d644c840e733 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -2428,9 +2428,9 @@ class V8_EXPORT String : public Name {
};
private:
- void VerifyExternalStringResourceBase(ExternalStringResourceBase* v,
+ friend class internal::Heap;
+ void VerifyExternalStringResourceBase(const ExternalStringResourceBase* v,
Encoding encoding) const;
- void VerifyExternalStringResource(ExternalStringResource* val) const;
static void CheckCast(v8::Value* obj);
};
@@ -7631,7 +7631,7 @@ String::ExternalStringResource* String::GetExternalStringResource() const {
result = NULL;
}
#ifdef V8_ENABLE_CHECKS
- VerifyExternalStringResource(result);
+ VerifyExternalStringResourceBase(result, TWO_BYTE_ENCODING);
#endif
return result;
}
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698