src/compiler/arm64/instruction-selector-arm64.cc - Issue 1149563004: [turbofan] Add bounds check to Node::InputAt(index) and fix tests that go out of bounds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/arm64/instruction-selector-arm64.cc

Issue 1149563004: [turbofan] Add bounds check to Node::InputAt(index) and fix tests that go out of bounds. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/arm64/instruction-selector-arm64.cc

diff --git a/src/compiler/arm64/instruction-selector-arm64.cc b/src/compiler/arm64/instruction-selector-arm64.cc

index d7d11702e4c99827521485ec95ebfcd6728abb8d..88871f5c572d1f379c206c1ace0f52df431ebc1d 100644

--- a/src/compiler/arm64/instruction-selector-arm64.cc

+++ b/src/compiler/arm64/instruction-selector-arm64.cc

@@ -1088,7 +1088,7 @@ void InstructionSelector::VisitTruncateFloat64ToFloat32(Node* node) {

void InstructionSelector::VisitTruncateInt64ToInt32(Node* node) {

Arm64OperandGenerator g(this);

Node* value = node->InputAt(0);

- if (CanCover(node, value)) {

+ if (CanCover(node, value) && value->InputCount() >= 2) {

Int64BinopMatcher m(value);

if ((m.IsWord64Sar() && m.right().HasValue() &&

(m.right().Value() == 32)) ||

« no previous file with comments | « no previous file | src/compiler/node.h » ('j') | no next file with comments »