Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1149563004: [turbofan] Add bounds check to Node::InputAt(index) and fix tests that go out of bounds. (Closed)

Created:
5 years, 7 months ago by titzer
Modified:
5 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add bounds check to Node::InputAt(index) and fix tests that go out of bounds. BUG= Committed: https://crrev.com/41795b8ae217271ff8cd1299716a8cd5f29dadc4 Cr-Commit-Position: refs/heads/master@{#28540}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -46 lines) Patch
M src/compiler/arm64/instruction-selector-arm64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/node.h View 1 chunk +9 lines, -1 line 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-osr.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 7 chunks +25 lines, -5 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 7 chunks +22 lines, -25 lines 0 comments Download
M test/unittests/compiler/scheduler-unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
titzer
5 years, 7 months ago (2015-05-20 18:50:36 UTC) #2
Michael Starzinger
LGTM.
5 years, 7 months ago (2015-05-21 07:56:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149563004/1
5 years, 7 months ago (2015-05-21 07:58:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/5890)
5 years, 7 months ago (2015-05-21 08:19:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149563004/20001
5 years, 7 months ago (2015-05-21 10:53:56 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-21 11:00:04 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 11:00:22 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/41795b8ae217271ff8cd1299716a8cd5f29dadc4
Cr-Commit-Position: refs/heads/master@{#28540}

Powered by Google App Engine
This is Rietveld 408576698