Issue 114953006: Add missing FileReader argument typechecking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 114953006: Add missing FileReader argument typechecking. (Closed)

Created:
7 years ago by sof

Modified:
7 years ago

Reviewers:
kinuko, michaeln, jianli

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Add missing FileReader argument typechecking. If the supplied argument to the readAs*() methods is not a Blob, throw the required TypeError. Also, improve the error message used when signalling attempts to concurrently read from the same FileReader object. R= BUG=223762 TEST=fast/files/file-reader-methods-illegal-arguments Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163944

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+93 lines, -13 lines)			Patch
A	LayoutTests/fast/files/file-reader-methods-illegal-arguments.html	View	1 chunk	+35 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/files/file-reader-methods-illegal-arguments-expected.txt	View	1 chunk	+37 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/files/read-file-async-expected.txt	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	LayoutTests/fast/files/workers/worker-read-file-async-expected.txt	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/core/fileapi/FileReader.cpp	View	5 chunks	+13 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/114953006/1

7 years ago (2013-12-16 06:10:24 UTC) #3

Message was sent while issue was closed.

Change committed as 163944

Expand Messages | Collapse Messages