Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1149453002: Removed project_bases_legacy_from_git_repo_url from V8 (Closed)

Created:
5 years, 7 months ago by Sergiy Byelozyorov
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Removed project_bases_legacy_from_git_repo_url from V8 This is not necessary because V8 is a Git-based project and relpath doesn't need to be computed. R=akuegel@chromium.org, machenbach@chromium.org BUG=471767 LOG=N Committed: https://crrev.com/dd26fbf2b5d69a336ce4eeb6a0edbafe2a73bd72 Cr-Commit-Position: refs/heads/master@{#28481}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M testing/commit_queue/config.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 21 (10 generated)
Sergiy Byelozyorov
5 years, 7 months ago (2015-05-19 12:52:43 UTC) #2
Adrian Kuegel
lgtm
5 years, 7 months ago (2015-05-19 12:53:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149453002/1
5 years, 7 months ago (2015-05-19 12:56:37 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-05-19 12:56:39 UTC) #8
Michael Achenbach
lgtm
5 years, 7 months ago (2015-05-19 13:40:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149453002/1
5 years, 7 months ago (2015-05-19 13:40:43 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/2770)
5 years, 7 months ago (2015-05-19 13:42:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149453002/1
5 years, 7 months ago (2015-05-19 13:44:02 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149453002/1
5 years, 7 months ago (2015-05-19 14:04:12 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 14:05:59 UTC) #20
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 14:06:13 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd26fbf2b5d69a336ce4eeb6a0edbafe2a73bd72
Cr-Commit-Position: refs/heads/master@{#28481}

Powered by Google App Engine
This is Rietveld 408576698