Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: unittest/BitcodeMunge.cpp

Issue 1149423011: Clean up unit munging unit tests using common NaCl API. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: unittest/BitcodeMunge.cpp
diff --git a/unittest/BitcodeMunge.cpp b/unittest/BitcodeMunge.cpp
index d258343380d41415d8016f20adda17bd804f7d30..a8d6566628a1afd85aec41b3eee96d0769e86a0d 100644
--- a/unittest/BitcodeMunge.cpp
+++ b/unittest/BitcodeMunge.cpp
@@ -33,14 +33,13 @@ void IceTest::SubzeroBitcodeMunger::resetMungeFlags() {
Flags.setVerbose(Ice::IceV_Instructions);
}
-bool IceTest::SubzeroBitcodeMunger::runTest(const char *TestName,
- const uint64_t Munges[],
+bool IceTest::SubzeroBitcodeMunger::runTest(const uint64_t Munges[],
size_t MungeSize) {
const bool AddHeader = true;
- setupTest(TestName, Munges, MungeSize, AddHeader);
+ setupTest(Munges, MungeSize, AddHeader);
Ice::GlobalContext Ctx(DumpStream, DumpStream, DumpStream, nullptr, Flags);
Ice::PNaClTranslator Translator(&Ctx);
- Translator.translateBuffer(TestName, MungedInput.get());
+ Translator.translateBuffer("Test", MungedInput.get());
Jim Stichnoth 2015/06/04 22:20:57 Maybe "document" the constant string argument usin
Karl 2015/06/08 16:25:40 Done.
cleanupTest();
return Translator.getErrorStatus().value() == 0;

Powered by Google App Engine
This is Rietveld 408576698