Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: runtime/observatory/lib/src/elements/flag_list.html

Issue 1149403007: Rework the format of the FlagList response. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/observatory/lib/src/elements/flag_list.dart ('k') | runtime/vm/flags.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="../../../../packages/polymer/polymer.html"> 1 <link rel="import" href="../../../../packages/polymer/polymer.html">
2 <link rel="import" href="nav_bar.html"> 2 <link rel="import" href="nav_bar.html">
3 <link rel="import" href="observatory_element.html"> 3 <link rel="import" href="observatory_element.html">
4 <link rel="import" href="view_footer.html"> 4 <link rel="import" href="view_footer.html">
5 5
6 <polymer-element name="flag-list" extends="observatory-element"> 6 <polymer-element name="flag-list" extends="observatory-element">
7 <template> 7 <template>
8 <link rel="stylesheet" href="css/shared.css"> 8 <link rel="stylesheet" href="css/shared.css">
9 <nav-bar> 9 <nav-bar>
10 <top-nav-menu></top-nav-menu> 10 <top-nav-menu></top-nav-menu>
11 <nav-menu link="{{ makeLink('/flags') }}" anchor="flags" last="{{ true }}" ></nav-menu> 11 <nav-menu link="{{ makeLink('/flags') }}" anchor="flags" last="{{ true }}" ></nav-menu>
12 <nav-refresh callback="{{ refresh }}"></nav-refresh> 12 <nav-refresh callback="{{ refresh }}"></nav-refresh>
13 </nav-bar> 13 </nav-bar>
14 14
15 <div class="content-centered"> 15 <div class="content-centered">
16 <template if="{{ flagList['modifiedFlags'].isNotEmpty }}"> 16 <template if="{{ modifiedFlags.isNotEmpty }}">
17 <h1>Modified Flags</h1> 17 <h1>Modified Flags</h1>
18 <br> 18 <br>
19 <template repeat="{{ flag in flagList['modifiedFlags'] }}"> 19 <template repeat="{{ flag in modifiedFlags }}">
20 <flag-item flag="{{ flag }}"></flag-item> 20 <flag-item flag="{{ flag }}"></flag-item>
21 <br> 21 <br>
22 </template> 22 </template>
23 <hr> 23 <hr>
24 </template> 24 </template>
25 25
26 <h1>Unmodified Flags</h1> 26 <h1>Unmodified Flags</h1>
27 <br> 27 <br>
28 <template if="{{ flagList['unmodifiedFlags'].isEmpty }}"> 28 <template if="{{ unmodifiedFlags.isEmpty }}">
29 <em>None</em> 29 <em>None</em>
30 </template> 30 </template>
31 <template if="{{ flagList['unmodifiedFlags'].isNotEmpty }}"> 31 <template if="{{ unmodifiedFlags.isNotEmpty }}">
32 <template repeat="{{ flag in flagList['unmodifiedFlags'] }}"> 32 <template repeat="{{ flag in unmodifiedFlags }}">
33 <flag-item flag="{{ flag }}"></flag-item> 33 <flag-item flag="{{ flag }}"></flag-item>
34 <br> 34 <br>
35 </template> 35 </template>
36 </template> 36 </template>
37 </div> 37 </div>
38 <view-footer></view-footer> 38 <view-footer></view-footer>
39 </template> 39 </template>
40 </polymer-element> 40 </polymer-element>
41 41
42 <polymer-element name="flag-item" extends="observatory-element"> 42 <polymer-element name="flag-item" extends="observatory-element">
43 <template> 43 <template>
44 <link rel="stylesheet" href="css/shared.css"> 44 <link rel="stylesheet" href="css/shared.css">
45 <span style="color:#aaa">// {{ flag['comment'] }}</span> 45 <span style="color:#aaa">// {{ flag['comment'] }}</span>
46 <div style="padding: 3px 0"> 46 <div style="padding: 3px 0">
47 <b>{{ flag['name'] }}</b> 47 <b>{{ flag['name'] }}</b>
48 &nbsp;=&nbsp; 48 &nbsp;=&nbsp;
49 {{ flag['valueAsString'] }} 49 {{ flag['valueAsString'] }}
50 </div> 50 </div>
51 </template> 51 </template>
52 </polymer-element> 52 </polymer-element>
53 53
54 <script type="application/dart" src="flag_list.dart"></script> 54 <script type="application/dart" src="flag_list.dart"></script>
OLDNEW
« no previous file with comments | « runtime/observatory/lib/src/elements/flag_list.dart ('k') | runtime/vm/flags.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698