Prevent excessive deoptimization when optimistically assuming Smi in typed data stores.

runtime/vm/deferred_objects.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/deferred_objects.h"
 
 #include "vm/code_patcher.h"
 #include "vm/compiler.h"
 #include "vm/deopt_instructions.h"
 #include "vm/flags.h"
@@ skipping 119 matching lines @@
   }
 
   uword pc = code.GetPcForDeoptId(deopt_id_, RawPcDescriptors::kIcCall);
   if (pc != 0) {
     // If the deoptimization happened at an IC call, update the IC data
     // to avoid repeated deoptimization at the same site next time around.
     ICData& ic_data = ICData::Handle(zone);
     CodePatcher::GetInstanceCallAt(pc, code, &ic_data);
     if (!ic_data.IsNull()) {
       ic_data.AddDeoptReason(deopt_context->deopt_reason());
+      // Propagate the reason to all ICData-s with same deopt_id since
+      // only unoptimized-code ICData (IC calls) are propagated.
+      function.SetDeoptReasonForAll(ic_data.deopt_id(),
+                                    deopt_context->deopt_reason());
     }
   } else {
     if (deopt_context->HasDeoptFlag(ICData::kHoisted)) {
       // Prevent excessive deoptimization.
       function.set_allows_hoisting_check_class(false);
     }
 
     if (deopt_context->HasDeoptFlag(ICData::kGeneralized)) {
       function.set_allows_bounds_check_generalization(false);
     }
@@ skipping 181 matching lines @@
           OS::PrintErr("    null Field @ offset(%" Pd ") <- %s\n",
                        offset.Value(),
                        value.ToCString());
         }
       }
     }
   }
 }
 
 }  // namespace dart