Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1716)

Unified Diff: content/common/service_worker/service_worker_messages.h

Issue 1149383004: [3/5 chromium] Shows the clients which are controlled by ServiceWorker in DevTools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: incorporated dcheng's comment Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/service_worker/service_worker_messages.h
diff --git a/content/common/service_worker/service_worker_messages.h b/content/common/service_worker/service_worker_messages.h
index 0710c45801310d4efb4ac7289e65bc5953c06f4c..91864fa3b2d5567bef9682761571587555bfd9a1 100644
--- a/content/common/service_worker/service_worker_messages.h
+++ b/content/common/service_worker/service_worker_messages.h
@@ -153,15 +153,16 @@ IPC_MESSAGE_CONTROL3(
std::vector<content::TransferredMessagePort> /* sent_message_ports */)
// Informs the browser of a new ServiceWorkerProvider in the child process,
-// |provider_id| is unique within its child process.
-// |render_frame_id| identifies the frame associated with the provider, it will
-// it will be MSG_ROUTING_NONE if the context is a worker instead of a document.
-// |provider_type| identifies whether this provider is for ServiceWorker
-// controllees (documents and SharedWorkers) or for controllers
-// (ServiceWorkers).
+// |provider_id| is unique within its child process. When this provider is
+// created for a document, |route_id| is the frame ID of it. When this provider
+// is created for a Shared Worker, |route_id| is the Shared Worker route ID.
+// When this provider is created for a Service Worker, |route_id| is
+// MSG_ROUTING_NONE. |provider_type| identifies whether this provider is for
+// Service Worker controllees (documents and Shared Workers) or for controllers
+// (Service Workers).
IPC_MESSAGE_CONTROL3(ServiceWorkerHostMsg_ProviderCreated,
int /* provider_id */,
- int /* render_frame_id */,
+ int /* route_id */,
content::ServiceWorkerProviderType /* provider_type */)
// Informs the browser of a ServiceWorkerProvider being destroyed.

Powered by Google App Engine
This is Rietveld 408576698