content/browser/service_worker/service_worker_version.h - Issue 1149383004: [3/5 chromium] Shows the clients which are controlled by ServiceWorker in DevTools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 1149383004: [3/5 chromium] Shows the clients which are controlled by ServiceWorker in DevTools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated dcheng's comment Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_provider_host.cc ('k') | content/browser/service_worker/service_worker_version.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_version.h

diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h

index d77ed99202c02013e012641c7be48c86996778c0..0d97f9455cc7baa774ed07eb3ddd173f10e61c21 100644

--- a/content/browser/service_worker/service_worker_version.h

+++ b/content/browser/service_worker/service_worker_version.h

@@ -110,6 +110,11 @@ class CONTENT_EXPORT ServiceWorkerVersion

const base::string16& message,

int line_number,

const GURL& source_url) {}

+ virtual void OnControlleeAdded(ServiceWorkerVersion* version,

+ ServiceWorkerProviderHost* provider_host) {}

+ virtual void OnControlleeRemoved(ServiceWorkerVersion* version,

+ ServiceWorkerProviderHost* provider_host) {

+ }

// Fires when a version transitions from having a controllee to not.

virtual void OnNoControllees(ServiceWorkerVersion* version) {}

virtual void OnCachedMetadataUpdated(ServiceWorkerVersion* version) {}