content/browser/service_worker/service_worker_dispatcher_host.cc - Issue 1149383004: [3/5 chromium] Shows the clients which are controlled by ServiceWorker in DevTools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host.cc

Issue 1149383004: [3/5 chromium] Shows the clients which are controlled by ServiceWorker in DevTools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated dcheng's comment Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_dispatcher_host.h ('k') | content/browser/service_worker/service_worker_info.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_dispatcher_host.cc

diff --git a/content/browser/service_worker/service_worker_dispatcher_host.cc b/content/browser/service_worker/service_worker_dispatcher_host.cc

index f65ee2decaa9edecc1c97463c2d1d90a4fc1665d..ff0c06564bc6b35025bf81220f460280e5ef5389 100644

--- a/content/browser/service_worker/service_worker_dispatcher_host.cc

+++ b/content/browser/service_worker/service_worker_dispatcher_host.cc

@@ -703,7 +703,7 @@ void ServiceWorkerDispatcherHost::OnPostMessageToWorker(

void ServiceWorkerDispatcherHost::OnProviderCreated(

int provider_id,

- int render_frame_id,

+ int route_id,

ServiceWorkerProviderType provider_type) {

// TODO(pkasting): Remove ScopedTracker below once crbug.com/477117 is fixed.

tracked_objects::ScopedTracker tracking_profile(

@@ -719,11 +719,8 @@ void ServiceWorkerDispatcherHost::OnProviderCreated(

return;

}

scoped_ptr<ServiceWorkerProviderHost> provider_host(

- new ServiceWorkerProviderHost(render_process_id_,

- render_frame_id,

- provider_id,

- provider_type,

- GetContext()->AsWeakPtr(),

+ new ServiceWorkerProviderHost(render_process_id_, route_id, provider_id,

+ provider_type, GetContext()->AsWeakPtr(),

this));

GetContext()->AddProviderHost(provider_host.Pass());

}