content/browser/devtools/protocol/service_worker_handler.h - Issue 1149383004: [3/5 chromium] Shows the clients which are controlled by ServiceWorker in DevTools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/service_worker_handler.h

Issue 1149383004: [3/5 chromium] Shows the clients which are controlled by ServiceWorker in DevTools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated dcheng's comment Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/devtools/protocol/service_worker_handler.h

diff --git a/content/browser/devtools/protocol/service_worker_handler.h b/content/browser/devtools/protocol/service_worker_handler.h

index 5c7c1ca0c0aacf8196f8f0ab4786a279bd09bfc1..b4906fe35ce2d5a11a92956b86c9a3e1304e382b 100644

--- a/content/browser/devtools/protocol/service_worker_handler.h

+++ b/content/browser/devtools/protocol/service_worker_handler.h

@@ -59,8 +59,11 @@ class ServiceWorkerHandler : public DevToolsAgentHostClient,

Response DeliverPushMessage(const std::string& origin,

const std::string& registration_id,

const std::string& data);

+ // TODO(horo): I will remove it in crrev.com/1143363009.

Response GetTargetInfo(DevToolsCommandId command_id,

const std::string& target_id);

+ Response GetTargetInfo(const std::string& target_id,

+ scoped_refptr<TargetInfo>* target_info);

Response ActivateTarget(const std::string& target_id);

// WorkerDevToolsManager::Observer implementation.

« no previous file with comments | « no previous file | content/browser/devtools/protocol/service_worker_handler.cc » ('j') | no next file with comments »