Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Unified Diff: content/browser/service_worker/service_worker_info.cc

Issue 1149383004: [3/5 chromium] Shows the clients which are controlled by ServiceWorker in DevTools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: incorporated nhiroki's comment Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_info.cc
diff --git a/content/browser/service_worker/service_worker_info.cc b/content/browser/service_worker/service_worker_info.cc
index 8c5f774abd0cf86e426d5bd9a1cb5d0f78312cb8..ea78965199945aeff06f232bf8667fd21964da75 100644
--- a/content/browser/service_worker/service_worker_info.cc
+++ b/content/browser/service_worker/service_worker_info.cc
@@ -9,6 +9,23 @@
namespace content {
+ServiceWorkerVersionInfo::ClientInfo::ClientInfo()
nhiroki 2015/06/12 05:48:01 Is this ctor used?
horo 2015/06/12 08:45:42 We need it to use ClientInfo as a value type of ma
+ : process_id(-1),
+ frame_id(MSG_ROUTING_NONE),
+ shared_worker_route_id(MSG_ROUTING_NONE) {
nhiroki 2015/06/12 05:48:01 How about using the delegated ctor?
horo 2015/06/12 08:45:42 Done.
+}
+
+ServiceWorkerVersionInfo::ClientInfo::ClientInfo(int process_id,
+ int frame_id,
+ int shared_worker_route_id)
+ : process_id(process_id),
+ frame_id(frame_id),
+ shared_worker_route_id(shared_worker_route_id) {
+}
+
+ServiceWorkerVersionInfo::ClientInfo::~ClientInfo() {
+}
+
ServiceWorkerVersionInfo::ServiceWorkerVersionInfo()
: running_status(ServiceWorkerVersion::STOPPED),
status(ServiceWorkerVersion::NEW),

Powered by Google App Engine
This is Rietveld 408576698