content/browser/service_worker/service_worker_request_handler_unittest.cc - Issue 1149383004: [3/5 chromium] Shows the clients which are controlled by ServiceWorker in DevTools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_request_handler_unittest.cc

Issue 1149383004: [3/5 chromium] Shows the clients which are controlled by ServiceWorker in DevTools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_provider_host.cc ('K') | « content/browser/service_worker/service_worker_provider_host_unittest.cc ('k') | content/browser/service_worker/service_worker_storage_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_request_handler_unittest.cc

diff --git a/content/browser/service_worker/service_worker_request_handler_unittest.cc b/content/browser/service_worker/service_worker_request_handler_unittest.cc

index 4d12e994a37d10057ef975b70c7b13cee7d09987..ad12e4dc07665f9659a361e49c8d035b822c5ee6 100644

--- a/content/browser/service_worker/service_worker_request_handler_unittest.cc

+++ b/content/browser/service_worker/service_worker_request_handler_unittest.cc

@@ -25,6 +25,7 @@ namespace content {

namespace {

int kMockRenderProcessId = 1224;

+int kMockRenderFrameId = 1;

int kMockProviderId = 1;

void EmptyCallback() {

@@ -51,8 +52,8 @@ class ServiceWorkerRequestHandlerTest : public testing::Test {

// An empty host.

scoped_ptr<ServiceWorkerProviderHost> host(new ServiceWorkerProviderHost(

- kMockRenderProcessId, MSG_ROUTING_NONE, kMockProviderId,

- SERVICE_WORKER_PROVIDER_FOR_WINDOW, context()->AsWeakPtr(), nullptr));

+ kMockRenderProcessId, kMockRenderFrameId, MSG_ROUTING_NONE,

+ kMockProviderId, context()->AsWeakPtr(), nullptr));

host->SetDocumentUrl(GURL("http://host/scope/"));

provider_host_ = host->AsWeakPtr();

context()->AddProviderHost(host.Pass());