Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: tools/telemetry/telemetry/results/results_options.py

Issue 1149373005: Revert of [Telemetry] Remove BuildbotOutputFormatter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/results/results_options.py
diff --git a/tools/telemetry/telemetry/results/results_options.py b/tools/telemetry/telemetry/results/results_options.py
index 04880322000612b733630427af4b9598759b0ce0..dd1cc7e4ccf23b303592735cf7e018ecb443aa8f 100644
--- a/tools/telemetry/telemetry/results/results_options.py
+++ b/tools/telemetry/telemetry/results/results_options.py
@@ -7,6 +7,7 @@
import sys
from telemetry.core import util
+from telemetry.results import buildbot_output_formatter
from telemetry.results import chart_json_output_formatter
from telemetry.results import csv_output_formatter
from telemetry.results import csv_pivot_table_output_formatter
@@ -17,8 +18,8 @@
from telemetry.results import progress_reporter
# Allowed output formats. The default is the first item in the list.
-_OUTPUT_FORMAT_CHOICES = ('html', 'csv', 'gtest', 'json', 'chartjson',
- 'csv-pivot-table', 'none')
+_OUTPUT_FORMAT_CHOICES = ('html', 'buildbot', 'csv', 'gtest', 'json',
+ 'chartjson', 'csv-pivot-table', 'none')
# Filenames to use for given output formats.
@@ -48,7 +49,7 @@
group.add_option('--output-trace-tag',
default='',
help='Append a tag to the key of each result trace. Use '
- 'with html, csv-pivot-table output formats.')
+ 'with html, buildbot, csv-pivot-table output formats.')
group.add_option('--reset-results', action='store_true',
help='Delete all stored results.')
group.add_option('--upload-results', action='store_true',
@@ -88,6 +89,9 @@
assert output_format not in ('gtest', 'none'), (
'Cannot set stream for \'gtest\' or \'none\' output formats.')
+ if output_format == 'buildbot':
+ return sys.stdout
+
assert output_format in _OUTPUT_FILENAME_LOOKUP, (
'No known filename for the \'%s\' output format' % output_format)
output_file = os.path.join(output_dir, _OUTPUT_FILENAME_LOOKUP[output_format])
@@ -125,9 +129,19 @@
output_formatters.append(
csv_pivot_table_output_formatter.CsvPivotTableOutputFormatter(
output_stream, trace_tag=options.output_trace_tag))
+ elif output_format == 'buildbot':
+ output_formatters.append(
+ buildbot_output_formatter.BuildbotOutputFormatter(
+ output_stream, trace_tag=options.output_trace_tag))
elif output_format == 'html':
- # TODO(eakuefner): Come up with some kind of progress reporter after
- # removing buildbot?
+ # TODO(chrishenry): We show buildbot output so that users can grep
+ # through the results easily without needing to open the html
+ # file. Another option for this is to output the results directly
+ # in gtest-style results (via some sort of progress reporter),
+ # as we plan to enable gtest-style output for all output formatters.
+ output_formatters.append(
+ buildbot_output_formatter.BuildbotOutputFormatter(
+ sys.stdout, trace_tag=options.output_trace_tag))
output_formatters.append(html_output_formatter.HtmlOutputFormatter(
output_stream, benchmark_metadata, options.reset_results,
options.upload_results, options.browser_type,
« no previous file with comments | « tools/telemetry/telemetry/results/buildbot_output_formatter.py ('k') | tools/telemetry/telemetry/value/failure.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698