Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: Source/core/dom/Range.h

Issue 1149373003: Remove Range.compareNode() as it is not in the spec (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: updated isNodeFullyContained Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Range.h
diff --git a/Source/core/dom/Range.h b/Source/core/dom/Range.h
index 4530f52e6006462f9530906fbdb6ff83397d87f4..763148e84ae39d96cecfcf02009e7f1e8e651dcd 100644
--- a/Source/core/dom/Range.h
+++ b/Source/core/dom/Range.h
@@ -81,9 +81,9 @@ public:
bool isPointInRange(Node* refNode, int offset, ExceptionState&);
short comparePoint(Node* refNode, int offset, ExceptionState&) const;
enum CompareResults { NODE_BEFORE, NODE_AFTER, NODE_BEFORE_AND_AFTER, NODE_INSIDE };
- CompareResults compareNode(Node* refNode, ExceptionState&) const;
enum CompareHow { START_TO_START, START_TO_END, END_TO_END, END_TO_START };
short compareBoundaryPoints(unsigned how, const Range* sourceRange, ExceptionState&) const;
+ bool isNodeFullyContained(Node&, ExceptionState&) const;
philipj_slow 2015/07/01 08:22:01 I'd move this up to before isPointInRange, it's od
deepak.s 2015/07/07 05:41:32 Done.
static short compareBoundaryPoints(Node* containerA, int offsetA, Node* containerB, int offsetB, ExceptionState&);
static short compareBoundaryPoints(const RangeBoundaryPoint& boundaryA, const RangeBoundaryPoint& boundaryB, ExceptionState&);
bool boundaryPointsValid() const;

Powered by Google App Engine
This is Rietveld 408576698