Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: net/quic/test_tools/crypto_test_utils.cc

Issue 114933003: Minor cleanup of QUIC MockConnection and PacketSavingConnection (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/reliable_quic_stream_test.cc ('k') | net/quic/test_tools/quic_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/test_tools/crypto_test_utils.cc
diff --git a/net/quic/test_tools/crypto_test_utils.cc b/net/quic/test_tools/crypto_test_utils.cc
index e14d7ab6e362731c2fc2b298b7816faa76210db6..97aa5c73ccc7643456fcd43b9cdc4ce850a8bece 100644
--- a/net/quic/test_tools/crypto_test_utils.cc
+++ b/net/quic/test_tools/crypto_test_utils.cc
@@ -133,12 +133,7 @@ CryptoTestUtils::FakeClientOptions::FakeClientOptions()
int CryptoTestUtils::HandshakeWithFakeServer(
PacketSavingConnection* client_conn,
QuicCryptoClientStream* client) {
- QuicGuid guid(1);
- IPAddressNumber ip;
- CHECK(ParseIPLiteralToNumber("192.0.2.33", &ip));
- IPEndPoint addr = IPEndPoint(ip, 1);
- PacketSavingConnection* server_conn =
- new PacketSavingConnection(guid, addr, true);
+ PacketSavingConnection* server_conn = new PacketSavingConnection(true);
TestSession server_session(server_conn, DefaultQuicConfig(), true);
QuicCryptoServerConfig crypto_config(QuicCryptoServerConfig::TESTING,
@@ -166,12 +161,7 @@ int CryptoTestUtils::HandshakeWithFakeClient(
PacketSavingConnection* server_conn,
QuicCryptoServerStream* server,
const FakeClientOptions& options) {
- QuicGuid guid(1);
- IPAddressNumber ip;
- CHECK(ParseIPLiteralToNumber("192.0.2.33", &ip));
- IPEndPoint addr = IPEndPoint(ip, 1);
- PacketSavingConnection* client_conn =
- new PacketSavingConnection(guid, addr, false);
+ PacketSavingConnection* client_conn = new PacketSavingConnection(false);
TestSession client_session(client_conn, DefaultQuicConfig(), false);
QuicCryptoClientConfig crypto_config;
« no previous file with comments | « net/quic/reliable_quic_stream_test.cc ('k') | net/quic/test_tools/quic_test_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698