Revert "dart2js: Do not emit type metadata for fields declared in non-reflectable classes."

pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js.js_emitter;
 
 class ClassEmitter extends CodeEmitterHelper {
 
   ClassStubGenerator get _stubGenerator =>
       new ClassStubGenerator(compiler, namer, backend);
@@ skipping 143 matching lines @@
           }
 
           int code = field.getterFlags + (field.setterFlags << 2);
           if (code == 0) {
             compiler.internalError(fieldElement,
                 'Field code is 0 ($fieldElement).');
           } else {
             fieldCode = FIELD_CODE_CHARACTERS[code - FIRST_FIELD_CODE];
           }
         }
-        // Fields can only be reflected if their declaring class is reflectable
-        // (as they are only accessible via [ClassMirror.declarations]).
-        // However, set/get operations can be performed on them, so they are
-        // reflectable in some sense, which leads to [isAccessibleByReflection]
-        // reporting `true`.
-        if (backend.isAccessibleByReflection(fieldElement) &&
-            (fieldElement.isTopLevel ||
-             backend.isAccessibleByReflection(fieldElement.enclosingClass))) {
+        if (backend.isAccessibleByReflection(fieldElement)) {
           DartType type = fieldElement.type;
           reflectionMarker = '-${task.metadataCollector.reifyType(type)}';
         }
         String builtFieldname = '$fieldName$fieldCode$reflectionMarker';
         builder.addField(builtFieldname);
         // Add 1 because adding a field to the class also requires a comma
         compiler.dumpInfoTask.recordFieldNameSize(fieldElement,
             builtFieldname.length + 1);
         fieldsAdded = true;
       }
@@ skipping 371 matching lines @@
         ? new Selector.getter(member.name, member.library)
         : new Selector.setter(member.name, member.library);
     String reflectionName = emitter.getReflectionName(selector, name);
     if (reflectionName != null) {
       var reflectable =
           js(backend.isAccessibleByReflection(member) ? '1' : '0');
       builder.addProperty('+$reflectionName', reflectable);
     }
   }
 }