Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1149323006: Gallery: capture escape key in full screen by adding a permission. (Closed)

Created:
5 years, 6 months ago by yawano
Modified:
5 years, 6 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gallery: capture escape key in full screen by adding a permission. BUG=497011 TEST=manually tested; Maximize Gallery and press slideshow button. Confirm that it goes to slideshow mode. After it, press escape key and confirm that it goes back to the original mode. Committed: https://crrev.com/7d1560ccb3dfee3c9f1510b035f67261b0b88d8f Cr-Commit-Position: refs/heads/master@{#333246}

Patch Set 1 #

Patch Set 2 : Remove unnecessary code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M ui/file_manager/gallery/js/slide_mode.js View 1 3 chunks +1 line, -15 lines 0 comments Download
M ui/file_manager/gallery/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
yawano
PTAL. Thank you!
5 years, 6 months ago (2015-06-08 06:47:36 UTC) #2
fukino
LGTM. Thanks!
5 years, 6 months ago (2015-06-08 07:07:24 UTC) #3
yawano
On 2015/06/08 07:07:24, fukino wrote: > LGTM. Thanks! Thank you!
5 years, 6 months ago (2015-06-08 07:07:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149323006/20001
5 years, 6 months ago (2015-06-08 07:08:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-08 07:11:45 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/7d1560ccb3dfee3c9f1510b035f67261b0b88d8f Cr-Commit-Position: refs/heads/master@{#333246}
5 years, 6 months ago (2015-06-08 07:12:38 UTC) #8
yawano
5 years, 6 months ago (2015-06-10 03:17:45 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1174733005/ by yawano@chromium.org.

The reason for reverting is: All of Gallery Material Redesign will happen in
M46..

Powered by Google App Engine
This is Rietveld 408576698