Upstream the iOS web_shell and supporting code

Upstream the iOS web_shell and supporting code

This upstreams the iOS app/ and shell/ directories.
- app/ is equivalent to the content/ versions, and is heavily based on
  that code.
- shell/ is the web_shell target, which is an incredibly stripped-down
  browser build on ios/web, in the spirit of content_shell.

Currently web_shell is extremely minimal, but allows basic browsing to
test ios/web/.

BUG=464810
Committed: https://crrev.com/a5df0663172d93a056cb74a034867c3f1e3b4a9b
Cr-Commit-Position: refs/heads/master@{#331526}

[stuartmorgan, 2015-05-22 22:32:22]

stuartmorgan@chromium.org changed reviewers:
+ eugenebut@chromium.org

[stuartmorgan, 2015-05-22 22:32:22]

Much of the app/ code is based on the content/ versions. In the future we may be
able to look at componentizing to share with content/ now that content/ can
depend on components, but upstreaming the existing code makes it easier to
evaluate that.

I'll rebase this once the images have landed, since I realized after uploading
that they should be split out into another CL for CQ purposes.

[rohitrao (ping after 24h), 2015-05-22 22:45:54]

rohitrao@chromium.org changed reviewers:
+ rohitrao@chromium.org

[rohitrao (ping after 24h), 2015-05-22 22:45:55]

https://codereview.chromium.org/1149323004/diff/1/ios/web/app/web_main_loop.mm
File ios/web/app/web_main_loop.mm (right):

https://codereview.chromium.org/1149323004/diff/1/ios/web/app/web_main_loop.m...
ios/web/app/web_main_loop.mm:223: // - The PROCESS_LAUNCHER thread must be
stopped after IO in case
Stale comment?

https://codereview.chromium.org/1149323004/diff/1/ios/web/app/web_main_loop.m...
ios/web/app/web_main_loop.mm:282: }  // namespace ios_web_shell
// namespace web

https://codereview.chromium.org/1149323004/diff/1/ios/web/app/web_main_runner.h
File ios/web/app/web_main_runner.h (right):

https://codereview.chromium.org/1149323004/diff/1/ios/web/app/web_main_runner...
ios/web/app/web_main_runner.h:5: #ifndef IOS_WEB_SHELL_WEB_MAIN_RUNNER_H_
Fix include guard.

[Eugene But (OOO till 7-30), 2015-05-22 23:13:27]

lgtm

https://codereview.chromium.org/1149323004/diff/1/ios/web/app/web_main_loop.mm
File ios/web/app/web_main_loop.mm (right):

https://codereview.chromium.org/1149323004/diff/1/ios/web/app/web_main_loop.m...
ios/web/app/web_main_loop.mm:77: #if !defined(OS_IOS)
Please remove

[rohitrao (ping after 24h), 2015-05-25 01:50:55]

https://codereview.chromium.org/1149323004/diff/1/ios/web/app/web_main_loop.mm
File ios/web/app/web_main_loop.mm (right):

https://codereview.chromium.org/1149323004/diff/1/ios/web/app/web_main_loop.m...
ios/web/app/web_main_loop.mm:77: #if !defined(OS_IOS)
On 2015/05/22 23:13:27, eugenebut wrote:
> Please remove

We should replace this with either a TODO or a bug to figure out what we want
wrt SystemMonitor.  I intentionally left this code in as a reminder.

[stuartmorgan, 2015-05-27 04:04:01]

https://codereview.chromium.org/1149323004/diff/1/ios/web/app/web_main_loop.mm
File ios/web/app/web_main_loop.mm (right):

https://codereview.chromium.org/1149323004/diff/1/ios/web/app/web_main_loop.m...
ios/web/app/web_main_loop.mm:77: #if !defined(OS_IOS)
On 2015/05/25 01:50:54, rohitrao wrote:
> On 2015/05/22 23:13:27, eugenebut wrote:
> > Please remove
> 
> We should replace this with either a TODO or a bug to figure out what we want
> wrt SystemMonitor.  I intentionally left this code in as a reminder.

For now I've made it an #if 0. The TODO and bug below track it.

https://codereview.chromium.org/1149323004/diff/1/ios/web/app/web_main_loop.m...
ios/web/app/web_main_loop.mm:223: // - The PROCESS_LAUNCHER thread must be
stopped after IO in case
On 2015/05/22 22:45:55, rohitrao wrote:
> Stale comment?

Yep, good catch.

https://codereview.chromium.org/1149323004/diff/1/ios/web/app/web_main_loop.m...
ios/web/app/web_main_loop.mm:282: }  // namespace ios_web_shell
On 2015/05/22 22:45:55, rohitrao wrote:
> // namespace web

Done.

https://codereview.chromium.org/1149323004/diff/1/ios/web/app/web_main_runner.h
File ios/web/app/web_main_runner.h (right):

https://codereview.chromium.org/1149323004/diff/1/ios/web/app/web_main_runner...
ios/web/app/web_main_runner.h:5: #ifndef IOS_WEB_SHELL_WEB_MAIN_RUNNER_H_
On 2015/05/22 22:45:55, rohitrao wrote:
> Fix include guard.

Done. Fixed several earlier, but apparently missed this one.

[stuartmorgan, 2015-05-27 04:04:11]

The CQ bit was checked by stuartmorgan@chromium.org

[stuartmorgan, 2015-05-27 04:04:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/1149323004/#ps40001
(title: "Address review comments")

[commit-bot: I haz the power, 2015-05-27 04:04:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1149323004/40001

[commit-bot: I haz the power, 2015-05-27 04:13:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-27 04:16:02]

Patchset 3 (id:??) landed as
https://crrev.com/a5df0663172d93a056cb74a034867c3f1e3b4a9b
Cr-Commit-Position: refs/heads/master@{#331526}

[rohitrao (ping after 24h), 2015-05-27 11:52:02]

I forgot to mention this when I reviewed last week, but does the toolbar have to
be that color?

[stuartmorgan, 2015-05-27 13:14:34]

On 2015/05/27 11:52:02, rohitrao wrote:
> I forgot to mention this when I reviewed last week, but does the toolbar have
to
> be that color?

I'm glad you asked! The exciting part is that now that web_shell is upstreamed,
we can put the question to chromium-dev and include the entire community in that
discussion.