go: Replace Logrus with go-logging.

go: Replace Logrus with go-logging.

The initial plan was to use glog. But glog turned out to be very rigid:
  * No way to expose command line flags via non-default flag parser.
  * No way to change logging level (and other configs) NOT via command line.
  * Non-configurable stack frame detector: all log lines are marked as produced
    by wrapping function, not where logger was called. (Wrapping functions are
    necessary to wrap glog global functions into Logger interface) -> useless.

go-logging was chosen as reasonably flexible library (like Logrus), that is
still pretty lightweight (no dependencies, unlike Logrus). Supports colors too!

R=iannucci@chromium.org, seanmccullough@chromium.org
BUG=

Committed: https://chromium.googlesource.com/infra/infra/+/36d0a36b0f90ef34686f738539a2756a4b068959

[Vadim Sh., 2015-05-21 23:15:16]

https://codereview.chromium.org/1149313002/diff/1/go/Goopfile
File go/Goopfile (right):

https://codereview.chromium.org/1149313002/diff/1/go/Goopfile#newcode24
go/Goopfile:24: github.com/op/go-logging
#b45e089a5a94cc79c8e78fc03cd83d04b5d8410f
will setup mirror now

[iannucci, 2015-05-21 23:19:23]

lgtm

https://codereview.chromium.org/1149313002/diff/2/go/Goopfile
File go/Goopfile (right):

https://codereview.chromium.org/1149313002/diff/2/go/Goopfile#newcode24
go/Goopfile:24: github.com/op/go-logging
#b45e089a5a94cc79c8e78fc03cd83d04b5d8410f
sort?

https://codereview.chromium.org/1149313002/diff/2/go/src/infra/libs/logging/g...
File go/src/infra/libs/logging/go-logging.go (right):

https://codereview.chromium.org/1149313002/diff/2/go/src/infra/libs/logging/g...
go/src/infra/libs/logging/go-logging.go:35: l.ExtraCalldepth = 2
2? not 1?

[Vadim Sh., 2015-05-21 23:24:50]

also removed IsTerminal, ptal

https://codereview.chromium.org/1149313002/diff/2/go/Goopfile
File go/Goopfile (right):

https://codereview.chromium.org/1149313002/diff/2/go/Goopfile#newcode24
go/Goopfile:24: github.com/op/go-logging
#b45e089a5a94cc79c8e78fc03cd83d04b5d8410f
On 2015/05/21 23:19:23, iannucci wrote:
> sort?

Done.

https://codereview.chromium.org/1149313002/diff/2/go/src/infra/libs/logging/g...
File go/src/infra/libs/logging/go-logging.go (right):

https://codereview.chromium.org/1149313002/diff/2/go/src/infra/libs/logging/g...
go/src/infra/libs/logging/go-logging.go:35: l.ExtraCalldepth = 2
On 2015/05/21 23:19:23, iannucci wrote:
> 2? not 1?

Don't know why. Found by experiment...

[iannucci, 2015-05-21 23:30:42]

lgtm though I'm wondering if 2 was due to reportError?

https://codereview.chromium.org/1149313002/diff/1/go/src/infra/tools/cipd/app...
File go/src/infra/tools/cipd/apps/cipd/main.go (right):

https://codereview.chromium.org/1149313002/diff/1/go/src/infra/tools/cipd/app...
go/src/infra/tools/cipd/apps/cipd/main.go:39: func reportError(format string,
params ...interface{}) {
yeah maybe we want to add a 'split logger' thingy at some point so you could tee
these off sensibly.

[seanmccullough, 2015-05-21 23:49:14]

lgtm

Not a huge fan of Warningf instead of Warnf but that's fine.

https://codereview.chromium.org/1149313002/diff/30001/go/src/infra/libs/loggi...
File go/src/infra/libs/logging/go-logging.go (right):

https://codereview.chromium.org/1149313002/diff/30001/go/src/infra/libs/loggi...
go/src/infra/libs/logging/go-logging.go:1: // Copyright 2014 The Chromium
Authors. All rights reserved.
2015?

https://codereview.chromium.org/1149313002/diff/30001/go/src/infra/libs/loggi...
go/src/infra/libs/logging/go-logging.go:31: l.ExtraCalldepth = 2
magic number?

[Vadim Sh., 2015-05-21 23:49:26]

ExtraCalldepth = 2 was due to additional layer of wrapping in functions like:

func Infof(...) {
  DefaultLogger.Infof(...)
}

Got rid of these functions.

https://codereview.chromium.org/1149313002/diff/1/go/src/infra/tools/cipd/app...
File go/src/infra/tools/cipd/apps/cipd/main.go (right):

https://codereview.chromium.org/1149313002/diff/1/go/src/infra/tools/cipd/app...
go/src/infra/tools/cipd/apps/cipd/main.go:39: func reportError(format string,
params ...interface{}) {
On 2015/05/21 23:30:42, iannucci wrote:
> yeah maybe we want to add a 'split logger' thingy at some point so you could
tee
> these off sensibly.

logging-go library supports it natively. I'm thinking about making it
configurable via some simpler interface... (and via cmd line too).

[iannucci, 2015-05-21 23:51:43]

lgtm. copyright update seems like a good nit :)

[Vadim Sh., 2015-05-21 23:53:32]

https://codereview.chromium.org/1149313002/diff/30001/go/src/infra/libs/loggi...
File go/src/infra/libs/logging/go-logging.go (right):

https://codereview.chromium.org/1149313002/diff/30001/go/src/infra/libs/loggi...
go/src/infra/libs/logging/go-logging.go:1: // Copyright 2014 The Chromium
Authors. All rights reserved.
On 2015/05/21 23:49:13, seanmccullough wrote:
> 2015?

Done.

https://codereview.chromium.org/1149313002/diff/30001/go/src/infra/libs/loggi...
go/src/infra/libs/logging/go-logging.go:31: l.ExtraCalldepth = 2
On 2015/05/21 23:49:14, seanmccullough wrote:
> magic number?

Not any more :) it's 1 now, added comment

[Vadim Sh., 2015-05-21 23:54:00]

The CQ bit was checked by vadimsh@chromium.org

[Vadim Sh., 2015-05-21 23:54:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
seanmccullough@chromium.org, iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/1149313002/#ps90001
(title: "typo")

[commit-bot: I haz the power, 2015-05-21 23:55:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1149313002/90001

[commit-bot: I haz the power, 2015-05-22 00:01:18]

Committed patchset #6 (id:90001) as
https://chromium.googlesource.com/infra/infra/+/36d0a36b0f90ef34686f738539a27...