Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in

Issue 1149303005: Remove --enable-ipv6 and --disable-ipv6 command line flags. (Closed)

4 years ago by cbentzel
4 years ago
Base URL:
Target Ref:


Remove --enable-ipv6 and --disable-ipv6 command line flags. These were introduced for debugging and corner-case purposes. However, these were not permanently supported configurations - policy support was never added, which is a key indicator that these are options which will be supported going into the future. --enable-ipv6 is hardly ever used. Internet searches for "--enable-ipv6 chrome" do not turn up many uses. --disable-ipv6 is used more regularly though. One place where --disable-ipv6 is used is in the SafeBrowsing tests. This was introduced in to help accelerate test cycle times. The main issue was windows was resolving localhost to ::1 which made tests flaky. The other general case where it has been used is when Chrome detects IPv6 availability but accesses are slow. Since this flag was added, Chrome added support for Happy Eyeballs, as well as improved the IPv6 probing for DNS, so the main motivations should be limited at this point. BUG=344685 Committed: Cr-Commit-Position: refs/heads/master@{#332245}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove extra newline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -28 lines) Patch
M chrome/browser/ View 1 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/safe_browsing/ View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/chrome_switches.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/ View 2 chunks +0 lines, -12 lines 0 comments Download


Total messages: 13 (3 generated)
mmenke: io_thread shess: safebrowsing_test My primary concern with this CL revolves around removing disable_ipv6 for ...
4 years ago (2015-06-01 16:40:31 UTC) #2
io_thread (And chrome_switches) LGTM File chrome/browser/ (left): chrome/browser/ global_host_resolver->SetDefaultAddressFamily(net::ADDRESS_FAMILY_IPV4); is now the ...
4 years ago (2015-06-01 17:05:54 UTC) #3
Scott Hess - ex-Googler
LGTM. I have no idea why this was landed, but it really sounds like something ...
4 years ago (2015-06-01 17:07:27 UTC) #4
On 2015/06/01 17:07:27, Scott Hess wrote: > LGTM. > > I have no idea why ...
4 years ago (2015-06-01 17:14:04 UTC) #5
cbentzel File chrome/browser/ (left): chrome/browser/ global_host_resolver->SetDefaultAddressFamily(net::ADDRESS_FAMILY_IPV4); On 2015/06/01 17:05:53, mmenke wrote: > is ...
4 years ago (2015-06-01 17:16:32 UTC) #6
4 years ago (2015-06-01 17:16:35 UTC) #7
4 years ago (2015-06-01 17:16:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at
4 years ago (2015-06-01 18:15:30 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2015-06-01 19:42:48 UTC) #12
commit-bot: I haz the power
4 years ago (2015-06-01 19:44:41 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
Cr-Commit-Position: refs/heads/master@{#332245}

Powered by Google App Engine
This is Rietveld 408576698