Chromium Code Reviews
Help | Chromium Project | Sign in
(8)

Issue 1149303005: Remove --enable-ipv6 and --disable-ipv6 command line flags. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 10 months ago by cbentzel
Modified:
1 year, 10 months ago
Reviewers:
mmenke, Scott Hess
CC:
chromium-reviews, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove --enable-ipv6 and --disable-ipv6 command line flags. These were introduced for debugging and corner-case purposes. However, these were not permanently supported configurations - policy support was never added, which is a key indicator that these are options which will be supported going into the future. --enable-ipv6 is hardly ever used. Internet searches for "--enable-ipv6 chrome" do not turn up many uses. --disable-ipv6 is used more regularly though. One place where --disable-ipv6 is used is in the SafeBrowsing tests. This was introduced in http://src.chromium.org/viewvc/chrome?revision=66196 to help accelerate test cycle times. The main issue was windows was resolving localhost to ::1 which made tests flaky. The other general case where it has been used is when Chrome detects IPv6 availability but accesses are slow. Since this flag was added, Chrome added support for Happy Eyeballs, as well as improved the IPv6 probing for DNS, so the main motivations should be limited at this point. BUG=344685 Committed: https://crrev.com/a391f4a06d66975a2a4da722ccd26935f39bd697 Cr-Commit-Position: refs/heads/master@{#332245}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove extra newline #

Messages

Total messages: 13 (3 generated)
cbentzel
mmenke: io_thread shess: safebrowsing_test My primary concern with this CL revolves around removing disable_ipv6 for ...
1 year, 10 months ago (2015-06-01 16:40:31 UTC) #2
mmenke
io_thread (And chrome_switches) LGTM https://codereview.chromium.org/1149303005/diff/1/chrome/browser/io_thread.cc File chrome/browser/io_thread.cc (left): https://codereview.chromium.org/1149303005/diff/1/chrome/browser/io_thread.cc#oldcode206 chrome/browser/io_thread.cc:206: global_host_resolver->SetDefaultAddressFamily(net::ADDRESS_FAMILY_IPV4); Hrm...net-internals is now the ...
1 year, 10 months ago (2015-06-01 17:05:54 UTC) #3
Scott Hess
LGTM. I have no idea why this was landed, but it really sounds like something ...
1 year, 10 months ago (2015-06-01 17:07:27 UTC) #4
cbentzel
On 2015/06/01 17:07:27, Scott Hess wrote: > LGTM. > > I have no idea why ...
1 year, 10 months ago (2015-06-01 17:14:04 UTC) #5
cbentzel
https://codereview.chromium.org/1149303005/diff/1/chrome/browser/io_thread.cc File chrome/browser/io_thread.cc (left): https://codereview.chromium.org/1149303005/diff/1/chrome/browser/io_thread.cc#oldcode206 chrome/browser/io_thread.cc:206: global_host_resolver->SetDefaultAddressFamily(net::ADDRESS_FAMILY_IPV4); On 2015/06/01 17:05:53, mmenke wrote: > Hrm...net-internals is ...
1 year, 10 months ago (2015-06-01 17:16:32 UTC) #6
cbentzel
1 year, 10 months ago (2015-06-01 17:16:35 UTC) #7
cbentzel
1 year, 10 months ago (2015-06-01 17:16:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149303005/20001
1 year, 10 months ago (2015-06-01 18:15:30 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
1 year, 10 months ago (2015-06-01 19:42:48 UTC) #12
commit-bot: I haz the power
1 year, 10 months ago (2015-06-01 19:44:41 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a391f4a06d66975a2a4da722ccd26935f39bd697
Cr-Commit-Position: refs/heads/master@{#332245}
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46