Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1149293009: Added tests for issue 1156353003, ability to distinguish between rich and plain text editable eleme… (Closed)

Created:
5 years, 6 months ago by nektarios
Modified:
5 years, 5 months ago
Reviewers:
dmazzoni
CC:
blink-reviews, je_julie, nektarios, dmazzoni, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Added tests for issue 1156353003, ability to distinguish between rich and plain text editable elements and text fields. I have to put the test in a separate CL because I have to modify content-shell's test runner. BUG=491027 R=dmazzoni Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198171

Patch Set 1 #

Patch Set 2 : Renamed to isRichlyEditable and added one more test case. #

Patch Set 3 : Updated expectations. #

Patch Set 4 : Renamed test file to match name of function being tested. #

Patch Set 5 : Changed property name from isContentRichlyEditable to isRichlyEditable. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -0 lines) Patch
A LayoutTests/accessibility/is-richly-editable.html View 1 2 3 4 1 chunk +60 lines, -0 lines 0 comments Download
A LayoutTests/accessibility/is-richly-editable-expected.txt View 1 2 3 4 1 chunk +31 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 23 (11 generated)
nektarios
5 years, 6 months ago (2015-06-04 01:17:57 UTC) #1
dmazzoni
lgtm Test looks great, thanks
5 years, 6 months ago (2015-06-04 03:41:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149293009/60001
5 years, 6 months ago (2015-06-23 16:52:58 UTC) #5
commit-bot: I haz the power
Exceeded global retry quota
5 years, 6 months ago (2015-06-23 17:54:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149293009/60001
5 years, 6 months ago (2015-06-23 17:57:11 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/60357)
5 years, 6 months ago (2015-06-23 19:07:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149293009/60001
5 years, 6 months ago (2015-06-23 19:36:28 UTC) #13
commit-bot: I haz the power
Exceeded global retry quota
5 years, 6 months ago (2015-06-23 21:21:01 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149293009/60001
5 years, 6 months ago (2015-06-23 21:33:45 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/60411)
5 years, 6 months ago (2015-06-23 22:32:53 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149293009/80001
5 years, 5 months ago (2015-07-01 21:40:06 UTC) #22
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 23:04:49 UTC) #23
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198171

Powered by Google App Engine
This is Rietveld 408576698