[MediaRouter] Adds GetPresentationServiceDelegate impl to ChromeContentBrowserClient

[MediaRouter] This patch connects PresentationServiceDelegateImpl to the presentation service for Chrome.

BUG=461815
Committed: https://crrev.com/9e605a9c86502ab870497a8e6db8674f18349bc0
Cr-Commit-Position: refs/heads/master@{#333211}

[haibinlu, 2015-06-04 00:24:50]

haibinlu@chromium.org changed reviewers:
+ kmarshall@chromium.org

[haibinlu, 2015-06-04 18:35:18]

haibinlu@chromium.org changed reviewers:
+ imcheng@chromium.org, mfoltz@chromium.org
- kmarshall@chromium.org

[imcheng (use chromium acct), 2015-06-04 18:48:36]

imcheng@google.com changed reviewers:
+ imcheng@google.com

[imcheng (use chromium acct), 2015-06-04 18:48:37]

Could you expand a little bit on the cl description, e.g., That this patch
connects PresentationServiceDelegateImpl to the presentation service for Chrome.

https://codereview.chromium.org/1149293008/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/presentation_service_delegate_impl.cc (right):

https://codereview.chromium.org/1149293008/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/presentation_service_delegate_impl.cc:334:
PresentationServiceDelegateImpl* delegateImpl =
s/delegateImpl/delegate_impl

https://codereview.chromium.org/1149293008/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/presentation_service_delegate_impl.cc:335:
PresentationServiceDelegateImpl::FromWebContents(web_contents);
You can just do the following:

// No-ops if it already exists.
PresentationServiceDelegateImpl::CreateForWebContents(web_contents);
return PresentationServiceDelegateImpl::FromWebContents(web_contents);

https://codereview.chromium.org/1149293008/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/presentation_service_delegate_impl.h (right):

https://codereview.chromium.org/1149293008/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/presentation_service_delegate_impl.h:49: static
PresentationServiceDelegateImpl* GetOrCreateForWebContents(
Documentation would be good here.

[haibinlu, 2015-06-04 20:25:45]

https://codereview.chromium.org/1149293008/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/presentation_service_delegate_impl.cc (right):

https://codereview.chromium.org/1149293008/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/presentation_service_delegate_impl.cc:334:
PresentationServiceDelegateImpl* delegateImpl =
On 2015/06/04 18:48:36, imcheng wrote:
> s/delegateImpl/delegate_impl

Done.

https://codereview.chromium.org/1149293008/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/presentation_service_delegate_impl.cc:335:
PresentationServiceDelegateImpl::FromWebContents(web_contents);
On 2015/06/04 18:48:36, imcheng wrote:
> You can just do the following:
> 
> // No-ops if it already exists.
> PresentationServiceDelegateImpl::CreateForWebContents(web_contents);
> return PresentationServiceDelegateImpl::FromWebContents(web_contents);

Done.

https://codereview.chromium.org/1149293008/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/presentation_service_delegate_impl.h (right):

https://codereview.chromium.org/1149293008/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/presentation_service_delegate_impl.h:49: static
PresentationServiceDelegateImpl* GetOrCreateForWebContents(
On 2015/06/04 18:48:36, imcheng wrote:
> Documentation would be good here.

Done.

[imcheng (use chromium acct), 2015-06-04 20:36:35]

lgtm

[mark a. foltz, 2015-06-05 22:22:19]

lgtm % one comment.

https://codereview.chromium.org/1149293008/diff/60001/chrome/browser/chrome_c...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/1149293008/diff/60001/chrome/browser/chrome_c...
chrome/browser/chrome_content_browser_client.cc:2379: #endif
#endif  // defined(ENABLE_MEDIA_ROUTER)

https://codereview.chromium.org/1149293008/diff/60001/chrome/browser/chrome_c...
chrome/browser/chrome_content_browser_client.cc:2379: #endif
Remove duplicate line by putting #endif before return nullptr.

[haibinlu, 2015-06-06 02:37:33]

https://codereview.chromium.org/1149293008/diff/60001/chrome/browser/chrome_c...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/1149293008/diff/60001/chrome/browser/chrome_c...
chrome/browser/chrome_content_browser_client.cc:2379: #endif
On 2015/06/05 22:22:19, mark a. foltz wrote:
> Remove duplicate line by putting #endif before return nullptr.

Done.

https://codereview.chromium.org/1149293008/diff/60001/chrome/browser/chrome_c...
chrome/browser/chrome_content_browser_client.cc:2379: #endif
On 2015/06/05 22:22:19, mark a. foltz wrote:
> #endif  // defined(ENABLE_MEDIA_ROUTER)

#if is very close by.

[haibinlu, 2015-06-06 02:37:40]

The CQ bit was checked by haibinlu@chromium.org

[haibinlu, 2015-06-06 02:37:40]

The patchset sent to the CQ was uploaded after l-g-t-m from imcheng@google.com,
mfoltz@chromium.org
Link to the patchset: https://codereview.chromium.org/1149293008/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-06-06 02:37:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1149293008/80001

[commit-bot: I haz the power, 2015-06-06 03:45:20]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-06-06 03:46:20]

Patchset 5 (id:??) landed as
https://crrev.com/9e605a9c86502ab870497a8e6db8674f18349bc0
Cr-Commit-Position: refs/heads/master@{#333211}