Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1149293005: Add ARM64 suppport to tools/grok_dump.py (Closed)

Created:
5 years, 6 months ago by ulan
Modified:
5 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add ARM64 suppport to grokdump.py Constants are taken from chromium/src/google_breakpad/common/minidump_cpu_arm64.h BUG= Committed: https://crrev.com/d903c5c0e55f7e3707bcc4390555bac21956c896 Cr-Commit-Position: refs/heads/master@{#28785}

Patch Set 1 #

Patch Set 2 : Fix accidental replace #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : Fix print #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -2 lines) Patch
M tools/grokdump.py View 1 2 3 17 chunks +88 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ulan
ptal
5 years, 6 months ago (2015-06-03 10:27:38 UTC) #2
Jakob Kummerow
Awesome, thank you very much! LGTM with a nit. https://codereview.chromium.org/1149293005/diff/20001/tools/grokdump.py File tools/grokdump.py (right): https://codereview.chromium.org/1149293005/diff/20001/tools/grokdump.py#newcode3188 tools/grokdump.py:3188: ...
5 years, 6 months ago (2015-06-03 10:41:49 UTC) #3
ulan
On 2015/06/03 10:41:49, Jakob wrote: > Awesome, thank you very much! LGTM with a nit. ...
5 years, 6 months ago (2015-06-03 10:43:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149293005/60001
5 years, 6 months ago (2015-06-03 10:44:17 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-03 11:07:28 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 11:07:43 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d903c5c0e55f7e3707bcc4390555bac21956c896
Cr-Commit-Position: refs/heads/master@{#28785}

Powered by Google App Engine
This is Rietveld 408576698