Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Unified Diff: build/android/findbugs_filter/findbugs_exclude.xml

Issue 1149283005: Roll src/third_party/android_protobuf 94f522f9:999188d0 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Findbugs exception seems to work. Made comment better. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/findbugs_filter/findbugs_exclude.xml
diff --git a/build/android/findbugs_filter/findbugs_exclude.xml b/build/android/findbugs_filter/findbugs_exclude.xml
index dbff9d9667fed37fc295c175aab79170b8c58f11..d7ed154aa6d0ce4ad268a236fd233815b2448e79 100644
--- a/build/android/findbugs_filter/findbugs_exclude.xml
+++ b/build/android/findbugs_filter/findbugs_exclude.xml
@@ -17,6 +17,12 @@ In particular, ~ at the start of a string means it's a regex.
<Match>
<Class name="~org\.chromium\..*\.Manifest(\$\w+)?" />
</Match>
+ <!-- Ignore harmless error in third_party/android_protobuf. -->
+ <Match>
+ <Class name="com.google.protobuf.nano.CodedInputByteBufferNano" />
+ <Method name="getBuffer" />
+ <Bug pattern="EI_EXPOSE_REP" />
+ </Match>
<Bug pattern="DM_STRING_CTOR" />
<!-- Ignore "reliance on default String encoding" warnings, as we're not multi-platform -->
<Bug pattern="DM_DEFAULT_ENCODING" />

Powered by Google App Engine
This is Rietveld 408576698