Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2397)

Unified Diff: chrome/browser/ui/panels/stacked_panel_collection.cc

Issue 1149263003: Add user_gesture param to BaseWindow::Activate Base URL: https://chromium.googlesource.com/chromium/src.git@ug2_WebContentsDelegate_ActivateContents
Patch Set: Update callers Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/stacked_panel_collection.cc
diff --git a/chrome/browser/ui/panels/stacked_panel_collection.cc b/chrome/browser/ui/panels/stacked_panel_collection.cc
index 7bcf5081967dca7784e798511f1161b65cb78576..c71971aec3de5bb4842be1b7fe03d91f39d10199 100644
--- a/chrome/browser/ui/panels/stacked_panel_collection.cc
+++ b/chrome/browser/ui/panels/stacked_panel_collection.cc
@@ -294,7 +294,8 @@ void StackedPanelCollection::RemovePanel(Panel* panel, RemovalReason reason) {
iter != most_recently_active_panels_.end(); ++iter) {
Panel* other_panel = *iter;
if (!IsPanelMinimized(other_panel)) {
- other_panel->Activate();
+ // TODO(johnme): Are there cases where this isn't a user gesture?
+ other_panel->Activate(true /* user_gesture */);
break;
}
}

Powered by Google App Engine
This is Rietveld 408576698